Commit 9d918828 authored by Coung Ngo's avatar Coung Ngo

Improve labels_select.js code

Improve code as a result of reviewer feedback
parent c4079d30
...@@ -3,7 +3,7 @@ ...@@ -3,7 +3,7 @@
/* global ListLabel */ /* global ListLabel */
import $ from 'jquery'; import $ from 'jquery';
import { difference, isEqual, escape, sortBy, template } from 'lodash'; import { difference, isEqual, escape, sortBy, template, union } from 'lodash';
import { sprintf, s__, __ } from './locale'; import { sprintf, s__, __ } from './locale';
import axios from './lib/utils/axios_utils'; import axios from './lib/utils/axios_utils';
import IssuableBulkUpdateActions from './issuable_bulk_update_actions'; import IssuableBulkUpdateActions from './issuable_bulk_update_actions';
...@@ -560,15 +560,15 @@ export default class LabelsSelect { ...@@ -560,15 +560,15 @@ export default class LabelsSelect {
IssuableBulkUpdateActions.willUpdateLabels = true; IssuableBulkUpdateActions.willUpdateLabels = true;
} }
// eslint-disable-next-line class-methods-use-this // eslint-disable-next-line class-methods-use-this
setDropdownData($dropdown, isChecking, labelId) { setDropdownData($dropdown, isMarking, labelId) {
let userCheckedIds = $dropdown.data('user-checked') || []; let userCheckedIds = $dropdown.data('user-checked') || [];
let userUncheckedIds = $dropdown.data('user-unchecked') || []; let userUncheckedIds = $dropdown.data('user-unchecked') || [];
if (isChecking) { if (isMarking) {
userCheckedIds = userCheckedIds.concat(labelId); userCheckedIds = union(userCheckedIds, [labelId]);
userUncheckedIds = difference(userUncheckedIds, [labelId]); userUncheckedIds = difference(userUncheckedIds, [labelId]);
} else { } else {
userUncheckedIds = userUncheckedIds.concat(labelId); userUncheckedIds = union(userUncheckedIds, [labelId]);
userCheckedIds = difference(userCheckedIds, [labelId]); userCheckedIds = difference(userCheckedIds, [labelId]);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment