Merge branch 'blackst0ne-remove-spinach-group-active-tab-feature' into 'master'

Remove `features/group_active_tab.feature`

See merge request gitlab-org/gitlab-ee!5554

ee/changelogs/unreleased/blackst0ne-remove-spinach-group-active-tab-feature.yml

+---
+title: 'Remove `features/group_active_tab.feature`'
+merge_request: 5554
+author: '@blackst0ne'
+type: other

features/group_active_tab.feature

-Feature: Group Active Tab
-#   Background:
-#     Given I sign in as "John Doe"
-#     And "John Doe" is owner of group "Owned"
-#     When I visit group "Owned" settings page
-#
-#   Scenario: On Audit events
-#     When I go to "Audit Events"
-#     Then the active sub nav should be Audit Events
-#     And no other sub navs should be active
-#     And the active main tab should be Settings
-#
-#   Scenario: On Webhooks
-#     When I go to "Webhooks"
-#     Then the active sub nav should be Webhooks
-#     And no other sub navs should be active
-#     And the active main tab should be Settings

features/steps/group_active_tab.rb

-class Spinach::Features::GroupActiveTab < Spinach::FeatureSteps
-  include SharedAuthentication
-  include SharedUser
-  include SharedGroup
-  include SharedPaths
-  include SharedActiveTab
-
-  step 'the active sub nav should be Audit Events' do
-    ensure_active_sub_nav('Audit Events')
-  end
-
-  step 'the active main tab should be Settings' do
-    page.within '.nav-sidebar' do
-      expect(page).to have_content('Go to group')
-    end
-  end
-
-  step 'the active sub nav should be Webhooks' do
-    ensure_active_sub_nav('Webhooks')
-  end
-
-  step 'I go to "Audit Events"' do
-    click_link 'Audit Events'
-  end
-
-  step 'I go to "Webhooks"' do
-    click_link 'Webhooks'
-  end
-end

features/steps/shared/active_tab.rb

@@ -25,8 +25,4 @@ module SharedActiveTab
   step 'no other sub tabs should be active' do
     expect(page).to have_selector('.sidebar-sub-level-items  > li.active:not(.fly-out-top-item)', count: 1)
   end
-
-  step 'no other sub navs should be active' do
-    expect(page).to have_selector('.layout-nav .controls li.active', count: 1)
-  end
 end

features/steps/shared/group.rb

@@ -5,10 +5,6 @@ module SharedGroup
     is_member_of(current_user.name, "Owned", Gitlab::Access::DEVELOPER)
   end
 
-  step '"John Doe" is owner of group "Owned"' do
-    is_member_of("John Doe", "Owned", Gitlab::Access::OWNER)
-  end
-
   step '"John Doe" is guest of group "Guest"' do
     is_member_of("John Doe", "Guest", Gitlab::Access::GUEST)
   end

features/steps/shared/paths.rb

@@ -48,10 +48,6 @@ module SharedPaths
     visit group_group_members_path(Group.find_by(name: "Owned"))
   end
 
-  step 'I visit group "Owned" settings page' do
-    visit edit_group_path(Group.find_by(name: "Owned"))
-  end
-
   step 'I visit group "Owned" projects page' do
     visit projects_group_path(Group.find_by(name: "Owned"))
   end