Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
a3264ca3
Commit
a3264ca3
authored
Feb 17, 2021
by
Mike Greiling
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix accessibility label for "start a new discussion"
parent
e3da53d8
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
11 additions
and
2 deletions
+11
-2
app/assets/javascripts/diffs/components/diff_discussion_reply.vue
...ts/javascripts/diffs/components/diff_discussion_reply.vue
+1
-0
app/assets/javascripts/notes/components/discussion_reply_placeholder.vue
...scripts/notes/components/discussion_reply_placeholder.vue
+10
-2
No files found.
app/assets/javascripts/diffs/components/diff_discussion_reply.vue
View file @
a3264ca3
...
...
@@ -36,6 +36,7 @@ export default {
<template
v-else-if=
"renderReplyPlaceholder"
>
<reply-placeholder
:placeholder-text=
"__('Start a new discussion…')"
:label-text=
"__('New discussion')"
@
focus=
"$emit('showNewDiscussionForm')"
/>
</
template
>
...
...
app/assets/javascripts/notes/components/discussion_reply_placeholder.vue
View file @
a3264ca3
<
script
>
import
{
__
}
from
'
~/locale
'
;
export
default
{
name
:
'
ReplyPlaceholder
'
,
props
:
{
placeholderText
:
{
type
:
String
,
required
:
true
,
required
:
false
,
default
:
__
(
'
Reply…
'
),
},
labelText
:
{
type
:
String
,
required
:
false
,
default
:
__
(
'
Reply to comment
'
),
},
},
};
...
...
@@ -16,7 +24,7 @@ export default {
rows=
"1"
class=
"reply-placeholder-text-field js-vue-discussion-reply"
:placeholder=
"placeholderText"
:aria-label=
"
__('Reply to comment')
"
:aria-label=
"
labelText
"
@
focus=
"$emit('focus')"
></textarea>
</
template
>
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment