Remove optimized_elasticsearch_indexes_project FF

This change removes the optimized_elasticsearch_indexes_project feature
flag.

ee/app/models/ee/application_setting.rb

@@ -136,10 +136,10 @@ module EE
       return false unless elasticsearch_indexing?
       return true unless elasticsearch_limit_indexing?
 
-      return optimized_elasticsearch_indexes_project?(project) unless ::Feature.enabled?(:elasticsearch_indexes_project_cache, default_enabled: true)
+      return elasticsearch_limited_project_exists?(project) unless ::Feature.enabled?(:elasticsearch_indexes_project_cache, default_enabled: true)
 
       ::Gitlab::Elastic::ElasticsearchEnabledCache.fetch(:project, project.id) do
-        optimized_elasticsearch_indexes_project?(project)
+        elasticsearch_limited_project_exists?(project)
       end
     end
 
@@ -298,8 +298,7 @@ module EE
 
     private
 
-    def optimized_elasticsearch_indexes_project?(project)
-      if ::Feature.enabled?(:optimized_elasticsearch_indexes_project, default_enabled: true)
+    def elasticsearch_limited_project_exists?(project)
       indexed_namespaces = ::Gitlab::ObjectHierarchy
         .new(::Namespace.where(id: project.namespace_id))
         .base_and_ancestors
@@ -312,10 +311,6 @@ module EE
         .from("(SELECT) as projects") # SELECT from "nothing" since the EXISTS queries have all the conditions.
         .merge(indexed_namespaces.or(indexed_projects))
         .exists?
-      else
-        # old behavior
-        elasticsearch_limited_projects.exists?(project.id)
-      end
     end
 
     def resume_elasticsearch_indexing

ee/changelogs/unreleased/216224_remove_optimized_elasticsearch_indexes_project_ff.yml

+---
+title: Remove optimized_elasticsearch_indexes_project feature flag
+merge_request: 33965
+author:
+type: other

ee/spec/models/application_setting_spec.rb

@@ -306,7 +306,6 @@ RSpec.describe ApplicationSetting do
         end
 
         describe '#elasticsearch_indexes_project?' do
-          shared_examples 'examples for #elasticsearch_indexes_project?' do
           context 'when project is in a subgroup' do
             let(:root_group) { create(:group) }
             let(:subgroup) { create(:group, parent: root_group) }
@@ -334,23 +333,6 @@ RSpec.describe ApplicationSetting do
             end
           end
         end
-
-          context 'when optimized_elasticsearch_indexes_project feature flag is on' do
-            before do
-              stub_feature_flags(optimized_elasticsearch_indexes_project: true)
-            end
-
-            include_examples 'examples for #elasticsearch_indexes_project?'
-          end
-
-          context 'when optimized_elasticsearch_indexes_project feature flag is off' do
-            before do
-              stub_feature_flags(optimized_elasticsearch_indexes_project: false)
-            end
-
-            include_examples 'examples for #elasticsearch_indexes_project?'
-          end
-        end
       end
 
       context 'projects' do