Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
aadf0181
Commit
aadf0181
authored
Aug 06, 2020
by
Tom Quirk
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Use testid to select design event element
parent
25a82d36
Changes
4
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
4 additions
and
4 deletions
+4
-4
app/assets/javascripts/design_management/components/list/item.vue
...ts/javascripts/design_management/components/list/item.vue
+1
-1
app/assets/javascripts/design_management_legacy/components/list/item.vue
...scripts/design_management_legacy/components/list/item.vue
+1
-1
spec/frontend/design_management/components/list/item_spec.js
spec/frontend/design_management/components/list/item_spec.js
+1
-1
spec/frontend/design_management_legacy/components/list/item_spec.js
...end/design_management_legacy/components/list/item_spec.js
+1
-1
No files found.
app/assets/javascripts/design_management/components/list/item.vue
View file @
aadf0181
...
@@ -130,7 +130,7 @@ export default {
...
@@ -130,7 +130,7 @@ export default {
class="card cursor-pointer text-plain js-design-list-item design-list-item design-list-item-new"
class="card cursor-pointer text-plain js-design-list-item design-list-item design-list-item-new"
>
>
<div
class=
"card-body p-0 d-flex-center overflow-hidden position-relative"
>
<div
class=
"card-body p-0 d-flex-center overflow-hidden position-relative"
>
<div
v-if=
"icon.name"
class=
"design-event position-absolute"
>
<div
v-if=
"icon.name"
data-testid=
"designEvent"
class=
"design-event position-absolute"
>
<span
:title=
"icon.tooltip"
:aria-label=
"icon.tooltip"
>
<span
:title=
"icon.tooltip"
:aria-label=
"icon.tooltip"
>
<icon
:name=
"icon.name"
:size=
"18"
:class=
"icon.classes"
/>
<icon
:name=
"icon.name"
:size=
"18"
:class=
"icon.classes"
/>
</span>
</span>
...
...
app/assets/javascripts/design_management_legacy/components/list/item.vue
View file @
aadf0181
...
@@ -130,7 +130,7 @@ export default {
...
@@ -130,7 +130,7 @@ export default {
class="card cursor-pointer text-plain js-design-list-item design-list-item"
class="card cursor-pointer text-plain js-design-list-item design-list-item"
>
>
<div
class=
"card-body p-0 d-flex-center overflow-hidden position-relative"
>
<div
class=
"card-body p-0 d-flex-center overflow-hidden position-relative"
>
<div
v-if=
"icon.name"
class=
"design-event position-absolute"
>
<div
v-if=
"icon.name"
data-testid=
"designEvent"
class=
"design-event position-absolute"
>
<span
:title=
"icon.tooltip"
:aria-label=
"icon.tooltip"
>
<span
:title=
"icon.tooltip"
:aria-label=
"icon.tooltip"
>
<icon
:name=
"icon.name"
:size=
"18"
:class=
"icon.classes"
/>
<icon
:name=
"icon.name"
:size=
"18"
:class=
"icon.classes"
/>
</span>
</span>
...
...
spec/frontend/design_management/components/list/item_spec.js
View file @
aadf0181
...
@@ -19,7 +19,7 @@ const DESIGN_VERSION_EVENT = {
...
@@ -19,7 +19,7 @@ const DESIGN_VERSION_EVENT = {
describe
(
'
Design management list item component
'
,
()
=>
{
describe
(
'
Design management list item component
'
,
()
=>
{
let
wrapper
;
let
wrapper
;
const
findDesignEvent
=
()
=>
wrapper
.
find
(
'
.design-event
'
);
const
findDesignEvent
=
()
=>
wrapper
.
find
(
'
[data-testid="designEvent"]
'
);
const
findEventIcon
=
()
=>
findDesignEvent
().
find
(
Icon
);
const
findEventIcon
=
()
=>
findDesignEvent
().
find
(
Icon
);
const
findLoadingIcon
=
()
=>
wrapper
.
find
(
GlLoadingIcon
);
const
findLoadingIcon
=
()
=>
wrapper
.
find
(
GlLoadingIcon
);
...
...
spec/frontend/design_management_legacy/components/list/item_spec.js
View file @
aadf0181
...
@@ -19,7 +19,7 @@ const DESIGN_VERSION_EVENT = {
...
@@ -19,7 +19,7 @@ const DESIGN_VERSION_EVENT = {
describe
(
'
Design management list item component
'
,
()
=>
{
describe
(
'
Design management list item component
'
,
()
=>
{
let
wrapper
;
let
wrapper
;
const
findDesignEvent
=
()
=>
wrapper
.
find
(
'
.design-event
'
);
const
findDesignEvent
=
()
=>
wrapper
.
find
(
'
[data-testid="designEvent"]
'
);
const
findEventIcon
=
()
=>
findDesignEvent
().
find
(
Icon
);
const
findEventIcon
=
()
=>
findDesignEvent
().
find
(
Icon
);
const
findLoadingIcon
=
()
=>
wrapper
.
find
(
GlLoadingIcon
);
const
findLoadingIcon
=
()
=>
wrapper
.
find
(
GlLoadingIcon
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment