Collapse begin/rescue into method

ab23a865 · mo khan · Ash McKenzie · ca1e2f89 · ab23a865
Commit ab23a865 authored Dec 05, 2019 by mo khan Committed by Ash McKenzie Dec 12, 2019
Show whitespace changes
Inline Side-by-side

Showing with 4 additions and 7 deletions

ee/app/services/software_license_policies/update_service.rb ee/app/services/software_license_policies/update_service.rb +4 -7

No files found.
--- a/ee/app/services/software_license_policies/update_service.rb
+++ b/ee/app/services/software_license_policies/update_service.rb
@@ -11,14 +11,11 @@ module SoftwareLicensePolicies
      return error("", 403) unless can?(@current_user, :admin_software_license_policy, @project)
      return success(software_license_policy: software_license_policy) unless params[:approval_status].present?

-      begin
      software_license_policy.update(classification: map_from(params[:approval_status]))
      RefreshLicenseComplianceChecksWorker.perform_async(project.id)
-      rescue ArgumentError => ex
-        return error(ex.message, 400)
-      end
-
      success(software_license_policy: software_license_policy)
+    rescue ArgumentError => ex
+      error(ex.message, 400)
    end

    private