Commit ac89878f authored by Tom Quirk's avatar Tom Quirk

Address frontend maintainer feedback

- Move all translated strings into i18n object.
parent 1c786a5b
...@@ -32,13 +32,15 @@ export default { ...@@ -32,13 +32,15 @@ export default {
i18n: { i18n: {
activeTableEmptyText: s__("Integrations|You haven't activated any integrations yet."), activeTableEmptyText: s__("Integrations|You haven't activated any integrations yet."),
inactiveTableEmptyText: s__("Integrations|You've activated every integration 🎉"), inactiveTableEmptyText: s__("Integrations|You've activated every integration 🎉"),
activeIntegrationsHeading: s__('Integrations|Active integrations'),
inactiveIntegrationsHeading: s__('Integrations|Add an integration'),
}, },
}; };
</script> </script>
<template> <template>
<div> <div>
<h4>{{ s__('Integrations|Active integrations') }}</h4> <h4>{{ $options.i18n.activeIntegrationsHeading }}</h4>
<integrations-table <integrations-table
class="gl-mb-7!" class="gl-mb-7!"
:integrations="integrationsGrouped.active" :integrations="integrationsGrouped.active"
...@@ -47,7 +49,7 @@ export default { ...@@ -47,7 +49,7 @@ export default {
data-testid="active-integrations-table" data-testid="active-integrations-table"
/> />
<h4>{{ s__('Integrations|Add an integration') }}</h4> <h4>{{ $options.i18n.inactiveIntegrationsHeading }}</h4>
<integrations-table <integrations-table
:integrations="integrationsGrouped.inactive" :integrations="integrationsGrouped.inactive"
:empty-text="$options.i18n.inactiveTableEmptyText" :empty-text="$options.i18n.inactiveTableEmptyText"
......
...@@ -74,7 +74,7 @@ export default { ...@@ -74,7 +74,7 @@ export default {
v-gl-tooltip v-gl-tooltip
name="check" name="check"
class="gl-text-green-500" class="gl-text-green-500"
:title="getStatusTooltipTitle(integration)" :title="getStatusTooltipTitle(item)"
/> />
</template> </template>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment