Commit aded595a authored by Kushal Pandya's avatar Kushal Pandya

Merge branch 'rename-create-issue' into 'master'

Rename Submit issue to Create issue in boards and docs

See merge request gitlab-org/gitlab!58243
parents b7049969 2aa8935b
...@@ -10,7 +10,7 @@ import ProjectSelect from './project_select.vue'; ...@@ -10,7 +10,7 @@ import ProjectSelect from './project_select.vue';
export default { export default {
name: 'BoardNewIssue', name: 'BoardNewIssue',
i18n: { i18n: {
submit: __('Submit issue'), submit: __('Create issue'),
cancel: __('Cancel'), cancel: __('Cancel'),
}, },
components: { components: {
......
...@@ -121,7 +121,7 @@ export default { ...@@ -121,7 +121,7 @@ export default {
variant="success" variant="success"
category="primary" category="primary"
type="submit" type="submit"
>{{ __('Submit issue') }}</gl-button >{{ __('Create issue') }}</gl-button
> >
<gl-button <gl-button
ref="cancelButton" ref="cancelButton"
......
---
title: Rename Submit issue to Create issue in boards and docs
merge_request: 58243
author: Yogi (@yo)
type: changed
...@@ -113,7 +113,7 @@ To create an issue: ...@@ -113,7 +113,7 @@ To create an issue:
1. Go to **Issues > List**. 1. Go to **Issues > List**.
1. In the top right, click **New issue**. 1. In the top right, click **New issue**.
1. Complete the fields. (If you have a reference topic that lists each field, link to it here.) 1. Complete the fields. (If you have a reference topic that lists each field, link to it here.)
1. Click **Submit issue**. 1. Click **Create issue**.
The issue is created. You can view it by going to **Issues > List**. The issue is created. You can view it by going to **Issues > List**.
``` ```
......
...@@ -39,7 +39,7 @@ Incident, you have two options to do this manually. ...@@ -39,7 +39,7 @@ Incident, you have two options to do this manually.
1. Go to **Issues > List**, and select **New issue**. 1. Go to **Issues > List**, and select **New issue**.
1. In the **Type** dropdown, select **Incident**. Only fields relevant to 1. In the **Type** dropdown, select **Incident**. Only fields relevant to
incidents are displayed on the page. incidents are displayed on the page.
1. Create the incident as needed, and select **Submit issue** to save the 1. Create the incident as needed, and select **Create issue** to save the
incident. incident.
![Incident List Create](img/new_incident_create_v13_4.png) ![Incident List Create](img/new_incident_create_v13_4.png)
......
...@@ -119,7 +119,7 @@ the unresolved threads. ...@@ -119,7 +119,7 @@ the unresolved threads.
![Issue mentioning threads in a merge request](img/preview_issue_for_threads.png) ![Issue mentioning threads in a merge request](img/preview_issue_for_threads.png)
Hitting **Submit issue** causes all threads to be marked as resolved and Hitting **Create issue** causes all threads to be marked as resolved and
add a note referring to the newly created issue. add a note referring to the newly created issue.
![Mark threads as resolved notice](img/resolve_thread_issue_notice.png) ![Mark threads as resolved notice](img/resolve_thread_issue_notice.png)
......
...@@ -19,7 +19,7 @@ You can make an issue confidential during issue creation or by editing ...@@ -19,7 +19,7 @@ You can make an issue confidential during issue creation or by editing
an existing one. an existing one.
When you create a new issue, a checkbox right below the text area is available When you create a new issue, a checkbox right below the text area is available
to mark the issue as confidential. Check that box and hit the **Submit issue** to mark the issue as confidential. Check that box and hit the **Create issue**
button to create the issue. For existing issues, edit them, check the button to create the issue. For existing issues, edit them, check the
confidential checkbox and hit **Save changes**. confidential checkbox and hit **Save changes**.
......
...@@ -27,7 +27,7 @@ RSpec.describe 'Issue Boards new issue', :js do ...@@ -27,7 +27,7 @@ RSpec.describe 'Issue Boards new issue', :js do
page.within(first('.board-new-issue-form')) do page.within(first('.board-new-issue-form')) do
find('.form-control').set('new issue') find('.form-control').set('new issue')
click_button 'Submit issue' click_button 'Create issue'
end end
wait_for_requests wait_for_requests
......
...@@ -137,7 +137,7 @@ RSpec.describe 'epics swimlanes', :js do ...@@ -137,7 +137,7 @@ RSpec.describe 'epics swimlanes', :js do
page.within(first('.board-new-issue-form')) do page.within(first('.board-new-issue-form')) do
find('.form-control').set('bug') find('.form-control').set('bug')
click_button 'Submit issue' click_button 'Create issue'
end end
wait_for_all_requests wait_for_all_requests
......
...@@ -29400,9 +29400,6 @@ msgstr "" ...@@ -29400,9 +29400,6 @@ msgstr ""
msgid "Submit feedback" msgid "Submit feedback"
msgstr "" msgstr ""
msgid "Submit issue"
msgstr ""
msgid "Submit review" msgid "Submit review"
msgstr "" msgstr ""
......
...@@ -60,7 +60,7 @@ RSpec.describe 'Issue Boards new issue', :js do ...@@ -60,7 +60,7 @@ RSpec.describe 'Issue Boards new issue', :js do
page.within(first('.board-new-issue-form')) do page.within(first('.board-new-issue-form')) do
find('.form-control').set('bug') find('.form-control').set('bug')
click_button 'Submit issue' click_button 'Create issue'
end end
wait_for_requests wait_for_requests
...@@ -85,7 +85,7 @@ RSpec.describe 'Issue Boards new issue', :js do ...@@ -85,7 +85,7 @@ RSpec.describe 'Issue Boards new issue', :js do
page.within(first('.board-new-issue-form')) do page.within(first('.board-new-issue-form')) do
find('.form-control').set('bug') find('.form-control').set('bug')
click_button 'Submit issue' click_button 'Create issue'
end end
wait_for_requests wait_for_requests
...@@ -100,7 +100,7 @@ RSpec.describe 'Issue Boards new issue', :js do ...@@ -100,7 +100,7 @@ RSpec.describe 'Issue Boards new issue', :js do
page.within(first('.board-new-issue-form')) do page.within(first('.board-new-issue-form')) do
find('.form-control').set('new issue') find('.form-control').set('new issue')
click_button 'Submit issue' click_button 'Create issue'
end end
wait_for_requests wait_for_requests
......
...@@ -33,7 +33,7 @@ RSpec.describe 'Group Boards' do ...@@ -33,7 +33,7 @@ RSpec.describe 'Group Boards' do
find('.gl-new-dropdown-item button').click find('.gl-new-dropdown-item button').click
end end
click_button 'Submit issue' click_button 'Create issue'
expect(page).to have_content(issue_title) expect(page).to have_content(issue_title)
end end
......
...@@ -121,7 +121,7 @@ RSpec.describe 'Users > Terms' do ...@@ -121,7 +121,7 @@ RSpec.describe 'Users > Terms' do
enforce_terms enforce_terms
click_button 'Submit issue' click_button 'Create issue'
expect(current_path).to eq(terms_path) expect(current_path).to eq(terms_path)
......
...@@ -111,7 +111,7 @@ describe('Issue boards new issue form', () => { ...@@ -111,7 +111,7 @@ describe('Issue boards new issue form', () => {
describe('submit success', () => { describe('submit success', () => {
it('creates new issue', () => { it('creates new issue', () => {
wrapper.setData({ title: 'submit issue' }); wrapper.setData({ title: 'create issue' });
return Vue.nextTick() return Vue.nextTick()
.then(submitIssue) .then(submitIssue)
...@@ -122,7 +122,7 @@ describe('Issue boards new issue form', () => { ...@@ -122,7 +122,7 @@ describe('Issue boards new issue form', () => {
it('enables button after submit', () => { it('enables button after submit', () => {
jest.spyOn(wrapper.vm, 'submit').mockImplementation(); jest.spyOn(wrapper.vm, 'submit').mockImplementation();
wrapper.setData({ title: 'submit issue' }); wrapper.setData({ title: 'create issue' });
return Vue.nextTick() return Vue.nextTick()
.then(submitIssue) .then(submitIssue)
...@@ -132,7 +132,7 @@ describe('Issue boards new issue form', () => { ...@@ -132,7 +132,7 @@ describe('Issue boards new issue form', () => {
}); });
it('clears title after submit', () => { it('clears title after submit', () => {
wrapper.setData({ title: 'submit issue' }); wrapper.setData({ title: 'create issue' });
return Vue.nextTick() return Vue.nextTick()
.then(submitIssue) .then(submitIssue)
...@@ -143,17 +143,17 @@ describe('Issue boards new issue form', () => { ...@@ -143,17 +143,17 @@ describe('Issue boards new issue form', () => {
it('sets detail issue after submit', () => { it('sets detail issue after submit', () => {
expect(boardsStore.detail.issue.title).toBe(undefined); expect(boardsStore.detail.issue.title).toBe(undefined);
wrapper.setData({ title: 'submit issue' }); wrapper.setData({ title: 'create issue' });
return Vue.nextTick() return Vue.nextTick()
.then(submitIssue) .then(submitIssue)
.then(() => { .then(() => {
expect(boardsStore.detail.issue.title).toBe('submit issue'); expect(boardsStore.detail.issue.title).toBe('create issue');
}); });
}); });
it('sets detail list after submit', () => { it('sets detail list after submit', () => {
wrapper.setData({ title: 'submit issue' }); wrapper.setData({ title: 'create issue' });
return Vue.nextTick() return Vue.nextTick()
.then(submitIssue) .then(submitIssue)
...@@ -164,7 +164,7 @@ describe('Issue boards new issue form', () => { ...@@ -164,7 +164,7 @@ describe('Issue boards new issue form', () => {
it('sets detail weight after submit', () => { it('sets detail weight after submit', () => {
boardsStore.weightFeatureAvailable = true; boardsStore.weightFeatureAvailable = true;
wrapper.setData({ title: 'submit issue' }); wrapper.setData({ title: 'create issue' });
return Vue.nextTick() return Vue.nextTick()
.then(submitIssue) .then(submitIssue)
...@@ -175,7 +175,7 @@ describe('Issue boards new issue form', () => { ...@@ -175,7 +175,7 @@ describe('Issue boards new issue form', () => {
it('does not set detail weight after submit', () => { it('does not set detail weight after submit', () => {
boardsStore.weightFeatureAvailable = false; boardsStore.weightFeatureAvailable = false;
wrapper.setData({ title: 'submit issue' }); wrapper.setData({ title: 'create issue' });
return Vue.nextTick() return Vue.nextTick()
.then(submitIssue) .then(submitIssue)
......
...@@ -86,7 +86,7 @@ describe('Issue boards new issue form', () => { ...@@ -86,7 +86,7 @@ describe('Issue boards new issue form', () => {
describe('submit success', () => { describe('submit success', () => {
it('creates new issue', async () => { it('creates new issue', async () => {
wrapper.setData({ title: 'submit issue' }); wrapper.setData({ title: 'create issue' });
await vm.$nextTick(); await vm.$nextTick();
await submitIssue(); await submitIssue();
...@@ -95,7 +95,7 @@ describe('Issue boards new issue form', () => { ...@@ -95,7 +95,7 @@ describe('Issue boards new issue form', () => {
it('enables button after submit', async () => { it('enables button after submit', async () => {
jest.spyOn(wrapper.vm, 'submit').mockImplementation(); jest.spyOn(wrapper.vm, 'submit').mockImplementation();
wrapper.setData({ title: 'submit issue' }); wrapper.setData({ title: 'create issue' });
await vm.$nextTick(); await vm.$nextTick();
await submitIssue(); await submitIssue();
...@@ -103,7 +103,7 @@ describe('Issue boards new issue form', () => { ...@@ -103,7 +103,7 @@ describe('Issue boards new issue form', () => {
}); });
it('clears title after submit', async () => { it('clears title after submit', async () => {
wrapper.setData({ title: 'submit issue' }); wrapper.setData({ title: 'create issue' });
await vm.$nextTick(); await vm.$nextTick();
await submitIssue(); await submitIssue();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment