Commit ae1b3a0e authored by Rémy Coutable's avatar Rémy Coutable

Merge branch 'Clean-Up-Substitution-warning-4' into 'master'

Clean up substitution warning 4

See merge request gitlab-org/gitlab!71109
parents 91cb8c31 8170a586
...@@ -141,7 +141,7 @@ at GitLab so far: ...@@ -141,7 +141,7 @@ at GitLab so far:
- Their availability: - Their availability:
- No "OOO"/"PTO"/"Parental Leave" in their GitLab or Slack status. - No "OOO"/"PTO"/"Parental Leave" in their GitLab or Slack status.
- No `:red_circle:`/`:palm_tree:`/`:beach:`/`:beach_umbrella:`/`:beach_with_umbrella:` emojis in GitLab or Slack status. - No `:red_circle:`/`:palm_tree:`/`:beach:`/`:beach_umbrella:`/`:beach_with_umbrella:` emojis in GitLab or Slack status.
- (Experimental) Their timezone: people for which the local hour is between - (Experimental) Their time zone: people for which the local hour is between
6 AM and 2 PM are eligible to be picked. This is to ensure they have a good 6 AM and 2 PM are eligible to be picked. This is to ensure they have a good
chance to get to perform a review during their current work day. The experimentation is tracked in chance to get to perform a review during their current work day. The experimentation is tracked in
[this issue](https://gitlab.com/gitlab-org/quality/team-tasks/-/issues/563) [this issue](https://gitlab.com/gitlab-org/quality/team-tasks/-/issues/563)
......
...@@ -50,6 +50,6 @@ Some additional information is included at the bottom of the comment: ...@@ -50,6 +50,6 @@ Some additional information is included at the bottom of the comment:
| Result | Description | | Result | Description |
|----------------------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| |----------------------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| Migrations pending on GitLab.com | A summary of migrations not deployed yet to GitLab.com. This info is useful when testing a migration that was merged but not deployed yet. | | Migrations pending on GitLab.com | A summary of migrations not deployed yet to GitLab.com. This information is useful when testing a migration that was merged but not deployed yet. |
| Clone details | A link to the `Postgres.ai` thin clone created for this testing pipeline, along with information about its expiry. This can be used to further explore the results of running the migration. Only accessible by database maintainers or with an access request. | | Clone details | A link to the `Postgres.ai` thin clone created for this testing pipeline, along with information about its expiry. This can be used to further explore the results of running the migration. Only accessible by database maintainers or with an access request. |
| Artifacts | A link to the pipeline's artifacts. Full query logs for each migration (ending in `.log`) are available there and only accessible by database maintainers or with an access request. | | Artifacts | A link to the pipeline's artifacts. Full query logs for each migration (ending in `.log`) are available there and only accessible by database maintainers or with an access request. |
...@@ -879,7 +879,7 @@ See the [text data type](database/strings_and_the_text_data_type.md) style guide ...@@ -879,7 +879,7 @@ See the [text data type](database/strings_and_the_text_data_type.md) style guide
## Timestamp column type ## Timestamp column type
By default, Rails uses the `timestamp` data type that stores timestamp data By default, Rails uses the `timestamp` data type that stores timestamp data
without timezone information. The `timestamp` data type is used by calling without time zone information. The `timestamp` data type is used by calling
either the `add_timestamps` or the `timestamps` method. either the `add_timestamps` or the `timestamps` method.
Also, Rails converts the `:datetime` data type to the `timestamp` one. Also, Rails converts the `:datetime` data type to the `timestamp` one.
...@@ -904,15 +904,15 @@ end ...@@ -904,15 +904,15 @@ end
``` ```
Instead of using these methods, one should use the following methods to store Instead of using these methods, one should use the following methods to store
timestamps with timezones: timestamps with time zones:
- `add_timestamps_with_timezone` - `add_timestamps_with_timezone`
- `timestamps_with_timezone` - `timestamps_with_timezone`
- `datetime_with_timezone` - `datetime_with_timezone`
This ensures all timestamps have a time zone specified. This, in turn, means This ensures all timestamps have a time zone specified. This, in turn, means
existing timestamps don't suddenly use a different timezone when the system's existing timestamps don't suddenly use a different time zone when the system's
timezone changes. It also makes it very clear which timezone was used in the time zone changes. It also makes it very clear which time zone was used in the
first place. first place.
## Storing JSON in database ## Storing JSON in database
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment