Switch to nested module and class definition

Switch to nested module and classes instead of compact
to follow this guideline:

https://github.com/rubocop/ruby-style-guide\#namespace-definition

app/services/ci/job_artifacts/create_service.rb

 # frozen_string_literal: true
 
 module Ci
-  class JobArtifacts::CreateService < ::BaseService
+  module JobArtifacts
+    class CreateService < ::BaseService
       include Gitlab::Utils::UsageData
 
       ArtifactsExistError = Class.new(StandardError)
@@ -169,4 +170,5 @@ module Ci
         Clusters::ParseClusterApplicationsArtifactService.new(job, job.user).execute(artifact)
       end
     end
+  end
 end

app/services/ci/job_artifacts/destroy_all_expired_service.rb

 # frozen_string_literal: true
 
 module Ci
-  class JobArtifacts::DestroyAllExpiredService
+  module JobArtifacts
+    class DestroyAllExpiredService
       include ::Gitlab::ExclusiveLeaseHelpers
       include ::Gitlab::LoopHelpers
 
@@ -53,4 +54,5 @@ module Ci
         Time.current > start_at + LOOP_TIMEOUT
       end
     end
+  end
 end

app/services/ci/job_artifacts/destroy_batch_service.rb

 # frozen_string_literal: true
 
 module Ci
-  class JobArtifacts::DestroyBatchService
+  module JobArtifacts
+    class DestroyBatchService
       include BaseServiceUtility
       include ::Gitlab::Utils::StrongMemoize
 
       # Danger: Private - Should only be called in Ci Services that pass a batch of job artifacts
-    # Not for use outsie of the ci namespace
+      # Not for use outside of the Ci:: namespace
 
       # Adds the passed batch of job artifacts to the `ci_deleted_objects` table
       # for asyncronous destruction of the objects in Object Storage via the `Ci::DeleteObjectsService`
@@ -67,6 +68,7 @@ module Ci
         end
       end
     end
+  end
 end
 
 Ci::JobArtifacts::DestroyBatchService.prepend_if_ee('EE::Ci::JobArtifacts::DestroyBatchService')

ee/app/services/ee/ci/job_artifacts/destroy_batch_service.rb

@@ -2,7 +2,8 @@
 
 module EE
   module Ci
-    module JobArtifacts::DestroyBatchService
+    module JobArtifacts
+      module DestroyBatchService
         extend ::Gitlab::Utils::Override
 
         private
@@ -19,4 +20,5 @@ module EE
         end
       end
     end
+  end
 end

spec/services/ci/job_artifacts/destroy_all_expired_service_spec.rb

@@ -24,7 +24,7 @@ RSpec.describe Ci::JobArtifacts::DestroyAllExpiredService, :clean_gitlab_redis_s
           job = create(:ci_build, pipeline: artifact.job.pipeline)
           create(:ci_job_artifact, :archive, :expired, job: job)
 
-          stub_const('Ci::JobArtifacts::DestroyAllExpiredService::LOOP_LIMIT', 1)
+          stub_const("#{described_class}::LOOP_LIMIT", 1)
         end
 
         it 'performs the smallest number of queries for job_artifacts' do
@@ -113,7 +113,7 @@ RSpec.describe Ci::JobArtifacts::DestroyAllExpiredService, :clean_gitlab_redis_s
 
     context 'when failed to destroy artifact' do
       before do
-        stub_const('Ci::JobArtifacts::DestroyAllExpiredService::LOOP_LIMIT', 10)
+        stub_const("#{described_class}::LOOP_LIMIT", 10)
       end
 
       context 'when the import fails' do
@@ -159,8 +159,8 @@ RSpec.describe Ci::JobArtifacts::DestroyAllExpiredService, :clean_gitlab_redis_s
       let!(:second_artifact) { create(:ci_job_artifact, expire_at: 1.day.ago) }
 
       before do
-        stub_const('Ci::JobArtifacts::DestroyAllExpiredService::LOOP_TIMEOUT', 0.seconds)
-        stub_const('Ci::JobArtifacts::DestroyAllExpiredService::BATCH_SIZE', 1)
+        stub_const("#{described_class}::LOOP_TIMEOUT", 0.seconds)
+        stub_const("#{described_class}::BATCH_SIZE", 1)
 
         second_artifact.job.pipeline.unlocked!
       end
@@ -176,8 +176,8 @@ RSpec.describe Ci::JobArtifacts::DestroyAllExpiredService, :clean_gitlab_redis_s
 
     context 'when loop reached loop limit' do
       before do
-        stub_const('Ci::JobArtifacts::DestroyAllExpiredService::LOOP_LIMIT', 1)
-        stub_const('Ci::JobArtifacts::DestroyAllExpiredService::BATCH_SIZE', 1)
+        stub_const("#{described_class}::LOOP_LIMIT", 1)
+        stub_const("#{described_class}::BATCH_SIZE", 1)
 
         second_artifact.job.pipeline.unlocked!
       end
@@ -209,7 +209,7 @@ RSpec.describe Ci::JobArtifacts::DestroyAllExpiredService, :clean_gitlab_redis_s
 
     context 'when there are artifacts more than batch sizes' do
       before do
-        stub_const('Ci::JobArtifacts::DestroyAllExpiredService::BATCH_SIZE', 1)
+        stub_const("#{described_class}::BATCH_SIZE", 1)
 
         second_artifact.job.pipeline.unlocked!
       end