Commit afbc1b22 authored by Sarah GP's avatar Sarah GP

Fix sliding issues

parent 5a539704
...@@ -28,7 +28,6 @@ export default { ...@@ -28,7 +28,6 @@ export default {
return { return {
currentPipeline: null, currentPipeline: null,
loadingPipelineId: null, loadingPipelineId: null,
minWidth: 0,
pipelineExpanded: false, pipelineExpanded: false,
}; };
}, },
...@@ -40,6 +39,7 @@ export default { ...@@ -40,6 +39,7 @@ export default {
'gl-pl-3', 'gl-pl-3',
'gl-mb-5', 'gl-mb-5',
], ],
minWidth: `${ONE_COL_WIDTH}px`,
computed: { computed: {
columnClass() { columnClass() {
const positionValues = { const positionValues = {
...@@ -48,12 +48,6 @@ export default { ...@@ -48,12 +48,6 @@ export default {
}; };
return `graph-position-${this.graphPosition} ${positionValues[this.graphPosition]}`; return `graph-position-${this.graphPosition} ${positionValues[this.graphPosition]}`;
}, },
graphPosition() {
return this.isUpstream ? 'left' : 'right';
},
isUpstream() {
return this.type === UPSTREAM;
},
computedTitleClasses() { computedTitleClasses() {
const positionalClasses = this.isUpstream const positionalClasses = this.isUpstream
? ['gl-w-full', 'gl-text-right', 'gl-linked-pipeline-padding'] ? ['gl-w-full', 'gl-text-right', 'gl-linked-pipeline-padding']
...@@ -61,6 +55,12 @@ export default { ...@@ -61,6 +55,12 @@ export default {
return [...this.$options.titleClasses, ...positionalClasses]; return [...this.$options.titleClasses, ...positionalClasses];
}, },
graphPosition() {
return this.isUpstream ? 'left' : 'right';
},
isUpstream() {
return this.type === UPSTREAM;
},
}, },
methods: { methods: {
getPipelineData(pipeline) { getPipelineData(pipeline) {
...@@ -105,7 +105,6 @@ export default { ...@@ -105,7 +105,6 @@ export default {
if (this.currentPipeline?.id === pipeline.id) { if (this.currentPipeline?.id === pipeline.id) {
this.pipelineExpanded = false; this.pipelineExpanded = false;
this.currentPipeline = null; this.currentPipeline = null;
this.minWidth = 0;
return; return;
} }
...@@ -120,11 +119,6 @@ export default { ...@@ -120,11 +119,6 @@ export default {
*/ */
this.pipelineExpanded = true; this.pipelineExpanded = true;
/*
Min-width is set manually for timing reasons.
*/
this.minWidth = `${ONE_COL_WIDTH}px`;
this.getPipelineData(pipeline); this.getPipelineData(pipeline);
}, },
onDownstreamHovered(jobName) { onDownstreamHovered(jobName) {
...@@ -138,6 +132,9 @@ export default { ...@@ -138,6 +132,9 @@ export default {
this.$emit('pipelineExpandToggle', jobName, expanded); this.$emit('pipelineExpandToggle', jobName, expanded);
}, },
showDownstreamContainer(id) {
return !this.isUpstream && (this.isExpanded(id) || this.isLoadingPipeline(id));
},
}, },
}; };
</script> </script>
...@@ -167,12 +164,12 @@ export default { ...@@ -167,12 +164,12 @@ export default {
@pipelineExpandToggle="onPipelineExpandToggle" @pipelineExpandToggle="onPipelineExpandToggle"
/> />
<div <div
v-if="isExpanded(pipeline.id) && !isUpstream" v-if="showDownstreamContainer(pipeline.id)"
:style="{ minWidth }" :style="{ minWidth: $options.minWidth }"
class="gl-display-inline-block" class="gl-display-inline-block"
> >
<pipeline-graph <pipeline-graph
v-if="currentPipeline" v-if="isExpanded(pipeline.id)"
:type="type" :type="type"
class="d-inline-block gl-mt-n2" class="d-inline-block gl-mt-n2"
:pipeline="currentPipeline" :pipeline="currentPipeline"
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment