Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
b07c0960
Commit
b07c0960
authored
Jan 24, 2020
by
Brett Walker
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Allow Boards:: ListService not to create default
board
parent
b9c77f7d
Changes
4
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
11 additions
and
5 deletions
+11
-5
app/graphql/resolvers/boards_resolver.rb
app/graphql/resolvers/boards_resolver.rb
+1
-1
app/services/boards/list_service.rb
app/services/boards/list_service.rb
+2
-2
spec/graphql/resolvers/boards_resolver_spec.rb
spec/graphql/resolvers/boards_resolver_spec.rb
+2
-2
spec/support/shared_examples/services/boards/boards_list_service_shared_examples.rb
...es/services/boards/boards_list_service_shared_examples.rb
+6
-0
No files found.
app/graphql/resolvers/boards_resolver.rb
View file @
b07c0960
...
...
@@ -12,7 +12,7 @@ module Resolvers
return
Board
.
none
unless
parent
Boards
::
ListService
.
new
(
parent
,
context
[
:current_user
]).
execute
Boards
::
ListService
.
new
(
parent
,
context
[
:current_user
]).
execute
(
create_default_board:
false
)
end
end
end
app/services/boards/list_service.rb
View file @
b07c0960
...
...
@@ -2,8 +2,8 @@
module
Boards
class
ListService
<
Boards
::
BaseService
def
execute
create_board!
if
parent
.
boards
.
empty?
def
execute
(
create_default_board:
true
)
create_board!
if
create_default_board
&&
parent
.
boards
.
empty?
if
parent
.
multiple_issue_boards_available?
boards
...
...
spec/graphql/resolvers/boards_resolver_spec.rb
View file @
b07c0960
...
...
@@ -8,8 +8,8 @@ describe Resolvers::BoardsResolver do
let_it_be
(
:user
)
{
create
(
:user
)
}
shared_examples_for
'group and project boards resolver'
do
it
'
creates the firs
t board'
do
expect
{
resolve_boards
}.
to
change
{
board_parent
.
boards
.
count
}.
from
(
0
).
to
(
1
)
it
'
does not create a defaul
t board'
do
expect
(
resolve_boards
).
to
eq
[]
end
it
'calls Boards::ListService'
do
...
...
spec/support/shared_examples/services/boards/boards_list_service_shared_examples.rb
View file @
b07c0960
...
...
@@ -11,6 +11,12 @@ RSpec.shared_examples 'boards list service' do
service
.
execute
end
context
'when create_default_board is false'
do
it
'does not create a new parent board'
do
expect
{
service
.
execute
(
create_default_board:
false
)
}.
not_to
change
(
parent
.
boards
,
:count
)
end
end
end
context
'when parent has a board'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment