Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
b49999ab
Commit
b49999ab
authored
Oct 25, 2021
by
Jose Vargas
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Close the registration dropdown after a token reset
parent
ea1e436a
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
11 additions
and
1 deletion
+11
-1
app/assets/javascripts/runner/components/registration/registration_dropdown.vue
.../runner/components/registration/registration_dropdown.vue
+9
-1
spec/features/admin/admin_runners_spec.rb
spec/features/admin/admin_runners_spec.rb
+2
-0
No files found.
app/assets/javascripts/runner/components/registration/registration_dropdown.vue
View file @
b49999ab
...
@@ -76,13 +76,21 @@ export default {
...
@@ -76,13 +76,21 @@ export default {
},
},
onTokenReset
(
token
)
{
onTokenReset
(
token
)
{
this
.
currentRegistrationToken
=
token
;
this
.
currentRegistrationToken
=
token
;
this
.
$refs
.
runnerRegistrationDropdown
.
hide
(
true
);
},
},
},
},
};
};
</
script
>
</
script
>
<
template
>
<
template
>
<gl-dropdown
menu-class=
"gl-w-auto!"
:text=
"dropdownText"
variant=
"confirm"
v-bind=
"$attrs"
>
<gl-dropdown
ref=
"runnerRegistrationDropdown"
menu-class=
"gl-w-auto!"
:text=
"dropdownText"
variant=
"confirm"
v-bind=
"$attrs"
>
<gl-dropdown-item
@
click.capture.native.stop=
"onShowInstructionsClick"
>
<gl-dropdown-item
@
click.capture.native.stop=
"onShowInstructionsClick"
>
{{
$options
.
i18n
.
showInstallationInstructions
}}
{{
$options
.
i18n
.
showInstallationInstructions
}}
<runner-instructions-modal
<runner-instructions-modal
...
...
spec/features/admin/admin_runners_spec.rb
View file @
b49999ab
...
@@ -323,6 +323,8 @@ RSpec.describe "Admin Runners" do
...
@@ -323,6 +323,8 @@ RSpec.describe "Admin Runners" do
end
end
it
'changes registration token'
do
it
'changes registration token'
do
click_on
'Register an instance runner'
click_on
'Click to reveal'
click_on
'Click to reveal'
expect
(
page_token
).
not_to
eq
token
expect
(
page_token
).
not_to
eq
token
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment