Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
b53ccd11
Commit
b53ccd11
authored
Jul 27, 2016
by
Phil Hughes
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fixed close merge request not hiding
parent
d6b7599d
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
2 additions
and
1 deletion
+2
-1
app/assets/javascripts/notes.js
app/assets/javascripts/notes.js
+1
-0
app/models/discussion.rb
app/models/discussion.rb
+1
-1
No files found.
app/assets/javascripts/notes.js
View file @
b53ccd11
...
@@ -600,6 +600,7 @@
...
@@ -600,6 +600,7 @@
form
.
find
(
"
#note_noteable_type
"
).
val
(
dataHolder
.
data
(
"
noteableType
"
));
form
.
find
(
"
#note_noteable_type
"
).
val
(
dataHolder
.
data
(
"
noteableType
"
));
form
.
find
(
"
#note_noteable_id
"
).
val
(
dataHolder
.
data
(
"
noteableId
"
));
form
.
find
(
"
#note_noteable_id
"
).
val
(
dataHolder
.
data
(
"
noteableId
"
));
form
.
find
(
'
.js-note-discard
'
).
show
().
removeClass
(
'
js-note-discard
'
).
addClass
(
'
js-close-discussion-note-form
'
).
text
(
form
.
find
(
'
.js-close-discussion-note-form
'
).
data
(
'
cancel-text
'
));
form
.
find
(
'
.js-note-discard
'
).
show
().
removeClass
(
'
js-note-discard
'
).
addClass
(
'
js-close-discussion-note-form
'
).
text
(
form
.
find
(
'
.js-close-discussion-note-form
'
).
data
(
'
cancel-text
'
));
form
.
find
(
'
.js-note-target-close
'
).
remove
();
if
(
canResolve
===
'
false
'
)
{
if
(
canResolve
===
'
false
'
)
{
form
.
find
(
'
resolve-comment-btn
'
).
remove
();
form
.
find
(
'
resolve-comment-btn
'
).
remove
();
...
...
app/models/discussion.rb
View file @
b53ccd11
...
@@ -76,7 +76,7 @@ class Discussion
...
@@ -76,7 +76,7 @@ class Discussion
return
false
unless
resolvable?
return
false
unless
resolvable?
current_user
==
self
.
noteable
.
author
||
current_user
==
self
.
noteable
.
author
||
c
an?
(
current_user
,
:push_code
,
self
.
project
)
c
urrent_user
.
can?
(
:push_code
,
self
.
project
)
end
end
def
resolve!
(
current_user
)
def
resolve!
(
current_user
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment