Merge branch '330941-remove-new_release_page-ff' into 'master'

Remove new_release_page feature flag [RUN ALL RSPEC] [RUN AS-IF-FOSS]

See merge request gitlab-org/gitlab!64153

app/controllers/projects/releases_controller.rb

@@ -25,12 +25,6 @@ class Projects::ReleasesController < Projects::ApplicationController
     end
   end
 
-  def new
-    unless Feature.enabled?(:new_release_page, project, default_enabled: true)
-      redirect_to(new_project_tag_path(@project))
-    end
-  end
-
   def downloads
     redirect_to link.url
   end

app/helpers/releases_helper.rb

@@ -20,11 +20,7 @@ module ReleasesHelper
       documentation_path: help_page
     }.tap do |data|
       if can?(current_user, :create_release, @project)
-        data[:new_release_path] = if Feature.enabled?(:new_release_page, @project, default_enabled: true)
-                                    new_project_release_path(@project)
-                                  else
-                                    new_project_tag_path(@project)
-                                  end
+        data[:new_release_path] = new_project_release_path(@project)
       end
     end
   end

config/feature_flags/development/new_release_page.yml

----
-name: new_release_page
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/35367
-rollout_issue_url: 
-milestone: '13.2'
-type: development
-group: group::release
-default_enabled: true

spec/helpers/releases_helper_spec.rb

@@ -48,16 +48,6 @@ RSpec.describe ReleasesHelper do
         it 'points new_release_path to the "New Release" page' do
           expect(helper.data_for_releases_page[:new_release_path]).to eq(new_project_release_path(project))
         end
-
-        context 'when the "new_release_page" feature flag is disabled' do
-          before do
-            stub_feature_flags(new_release_page: false)
-          end
-
-          it 'points new_release_path to the "New Tag" page' do
-            expect(helper.data_for_releases_page[:new_release_path]).to eq(new_project_tag_path(project))
-          end
-        end
       end
     end