Commit b752ee4a authored by Jacopo's avatar Jacopo

Updates after 4th review

parent 2c86a0f8
...@@ -39,6 +39,26 @@ describe RuboCop::Cop::AvoidReturnFromBlocks do ...@@ -39,6 +39,26 @@ describe RuboCop::Cop::AvoidReturnFromBlocks do
inspect_source(source) inspect_source(source)
end end
it 'flags violation for return inside included > def > block' do
source = <<~RUBY
included do
def a_method
return if something
call do
return if something_else
end
end
end
RUBY
inspect_source(source)
expect(cop.offenses.size).to eq(1)
offense = cop.offenses.first
expect(offense.line).to eq(6)
end
shared_examples 'examples with whitelisted method' do |whitelisted_method| shared_examples 'examples with whitelisted method' do |whitelisted_method|
it "doesn't flag violation for return inside #{whitelisted_method}" do it "doesn't flag violation for return inside #{whitelisted_method}" do
source = <<~RUBY source = <<~RUBY
...@@ -64,7 +84,7 @@ describe RuboCop::Cop::AvoidReturnFromBlocks do ...@@ -64,7 +84,7 @@ describe RuboCop::Cop::AvoidReturnFromBlocks do
#{def_method} do #{def_method} do
return if something return if something
do_something_mode do_something_more
end end
end end
RUBY RUBY
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment