Commit b9bd0a86 authored by David Kim's avatar David Kim

Merge branch 'fix-predefined-metrics-dashboard-autoload' into 'master'

Fix preloaded dashboards when not eager loading

See merge request gitlab-org/gitlab!64691
parents c0a53132 98fbf785
......@@ -7,14 +7,9 @@ module Gitlab
module Metrics
module Dashboard
class Finder
# Dashboards that should not be part of the list of all dashboards
# displayed on the metrics dashboard page.
PREDEFINED_DASHBOARD_EXCLUSION_LIST = [
# This dashboard is only useful in the self monitoring project.
::Metrics::Dashboard::SelfMonitoringDashboardService,
# This dashboard is displayed on the K8s cluster settings health page.
::Metrics::Dashboard::ClusterDashboardService
PREDEFINED_DASHBOARD_LIST = [
::Metrics::Dashboard::PodDashboardService,
::Metrics::Dashboard::SystemDashboardService
].freeze
class << self
......@@ -90,11 +85,7 @@ module Gitlab
return [self_monitoring_service]
end
predefined_dashboard_services
end
def predefined_dashboard_services
::Metrics::Dashboard::PredefinedDashboardService.descendants - PREDEFINED_DASHBOARD_EXCLUSION_LIST
PREDEFINED_DASHBOARD_LIST
end
def system_service
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment