Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
babb2523
Commit
babb2523
authored
Jan 06, 2021
by
Kev
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix 'copy sha' in 'add previous commits' modal doesn't copy
parent
e59fa655
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
8 additions
and
3 deletions
+8
-3
app/assets/javascripts/diffs/components/commit_item.vue
app/assets/javascripts/diffs/components/commit_item.vue
+3
-3
changelogs/unreleased/238854-fix-copy-sha-in-add-previous-commits-modal-doesnt-copy.yml
...ix-copy-sha-in-add-previous-commits-modal-doesnt-copy.yml
+5
-0
No files found.
app/assets/javascripts/diffs/components/commit_item.vue
View file @
babb2523
...
...
@@ -6,7 +6,7 @@ import { GlButtonGroup, GlButton, GlTooltipDirective, GlIcon } from '@gitlab/ui'
import
glFeatureFlagsMixin
from
'
~/vue_shared/mixins/gl_feature_flags_mixin
'
;
import
UserAvatarLink
from
'
~/vue_shared/components/user_avatar/user_avatar_link.vue
'
;
import
ClipboardButton
from
'
~/vue_shared/components/clipboard
_button.vue
'
;
import
ModalCopyButton
from
'
~/vue_shared/components/modal_copy
_button.vue
'
;
import
TimeAgoTooltip
from
'
~/vue_shared/components/time_ago_tooltip.vue
'
;
import
CommitPipelineStatus
from
'
~/projects/tree/components/commit_pipeline_status_component.vue
'
;
...
...
@@ -39,7 +39,7 @@ import { setUrlParams } from '../../lib/utils/url_utility';
export
default
{
components
:
{
UserAvatarLink
,
Clipboard
Button
,
ModalCopy
Button
,
TimeAgoTooltip
,
CommitPipelineStatus
,
GlButtonGroup
,
...
...
@@ -142,7 +142,7 @@ export default {
data-testid=
"commit-sha-short-id"
v-text=
"commit.short_id"
/>
<
clipboard
-button
<
modal-copy
-button
:text=
"commit.id"
:title=
"__('Copy commit SHA')"
class=
"input-group-text"
...
...
changelogs/unreleased/238854-fix-copy-sha-in-add-previous-commits-modal-doesnt-copy.yml
0 → 100644
View file @
babb2523
---
title
:
Fix 'copy sha' in 'add previous commits' modal doesn't copy
merge_request
:
50921
author
:
Kev @KevSlashNull
type
:
fixed
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment