Add latest changes from gitlab-org/gitlab@master

doc/user/project/merge_requests/code_quality.md

@@ -66,6 +66,19 @@ will scan your source code for code quality issues. The report will be saved as
 that you can later download and analyze. Due to implementation limitations we always
 take the latest Code Quality artifact available.
 
+It is also possible to override the URL to the Code Quality image by
+setting the `CODE_QUALITY_IMAGE` variable. This is particularly useful if you want
+to lock in a specific version of Code Quality, or use a fork of it:
+
+```yaml
+include:
+  - template: Code-Quality.gitlab-ci.yml
+
+code_quality:
+  variables:
+    CODE_QUALITY_IMAGE: "registry.example.com/codequality-fork:latest"
+```
+
 By default, report artifacts are not downloadable. If you need them downloadable on the
 job details page, you can add `gl-code-quality-report.json` to the artifact paths like so:
 
@@ -125,6 +138,33 @@ code_quality:
       codequality: gl-code-quality-report.json
 ```
 
+In GitLab 12.6, Code Quality switched to the
+[new versioning scheme](https://gitlab.com/gitlab-org/security-products/codequality/merge_requests/38).
+It is highly recommended to include the Code Quality template as shown in the
+[example configuration](#example-configuration), which uses the new versioning scheme.
+If not using the template, the `SP_VERSION` variable can be hardcoded to use the
+new image versions:
+
+```yaml
+code_quality:
+  image: docker:stable
+  variables:
+    DOCKER_DRIVER: overlay2
+    SP_VERSION: 0.85.6
+  allow_failure: true
+  services:
+    - docker:stable-dind
+  script:
+    - docker run
+        --env SOURCE_CODE="$PWD"
+        --volume "$PWD":/code
+        --volume /var/run/docker.sock:/var/run/docker.sock
+        "registry.gitlab.com/gitlab-org/security-products/codequality:$SP_VERSION" /code
+  artifacts:
+    reports:
+      codequality: gl-code-quality-report.json
+```
+
 For GitLab 11.4 and earlier, the job should look like:
 
 ```yaml

qa/qa/page/layout/performance_bar.rb

@@ -21,7 +21,7 @@ module QA
           has_element?(:performance_bar)
         end
 
-        def has_detailed_metrics?
+        def has_detailed_metrics?(count)
           retry_until(sleep_interval: 1) do
             all_elements(:detailed_metric_content, count: count).all? do |metric|
               metric.has_text?(%r{\d+})

qa/qa/specs/features/browser_ui/non_devops/performance_bar_spec.rb

 # frozen_string_literal: true
 
 module QA
-  context 'Performance bar' do
-    context 'when logged in as an admin user', :requires_admin, quarantine: 'https://gitlab.com/gitlab-org/gitlab/issues/196141' do
+  context 'Non-devops' do
+    describe 'Performance bar display', :requires_admin, quarantine: 'https://gitlab.com/gitlab-org/gitlab/issues/196141' do
+      context 'when logged in as an admin user' do
+        # 4 metrics: pg, gitaly, redis, total
+        let(:metrics_count) { 4 }
+
         before do
           Flow::Login.sign_in_as_admin
           Page::Main::Menu.perform(&:go_to_admin_area)
@@ -24,10 +28,11 @@ module QA
 
           Page::Layout::PerformanceBar.perform do |bar_component|
             expect(bar_component).to have_performance_bar
-          expect(bar_component).to have_detailed_metrics(4)
+            expect(bar_component).to have_detailed_metrics(metrics_count)
             expect(bar_component).to have_request_for('realtime_changes') # Always requested on issue pages
           end
         end
       end
     end
+  end
 end