Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
bb0884b0
Commit
bb0884b0
authored
Jul 06, 2017
by
Nick Thomas
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Resolve merge conflicts from EE master -> ce-to-ee
parent
acce84d4
Changes
6
Show whitespace changes
Inline
Side-by-side
Showing
6 changed files
with
0 additions
and
76 deletions
+0
-76
app/helpers/form_helper.rb
app/helpers/form_helper.rb
+0
-4
app/models/concerns/issuable.rb
app/models/concerns/issuable.rb
+0
-7
app/services/quick_actions/interpret_service.rb
app/services/quick_actions/interpret_service.rb
+0
-37
app/views/shared/issuable/_sidebar_assignees.html.haml
app/views/shared/issuable/_sidebar_assignees.html.haml
+0
-4
spec/features/issues/form_spec.rb
spec/features/issues/form_spec.rb
+0
-5
spec/services/quick_actions/interpret_service_spec.rb
spec/services/quick_actions/interpret_service_spec.rb
+0
-19
No files found.
app/helpers/form_helper.rb
View file @
bb0884b0
...
@@ -30,11 +30,7 @@ module FormHelper
...
@@ -30,11 +30,7 @@ module FormHelper
null_user:
true
,
null_user:
true
,
current_user:
true
,
current_user:
true
,
project_id:
@project
.
id
,
project_id:
@project
.
id
,
<<<<<<<
HEAD
field_name:
'issue[assignee_ids][]'
,
=======
field_name:
"issue[assignee_ids][]"
,
field_name:
"issue[assignee_ids][]"
,
>>>>>>>
upstream
/
master
default_label:
'Unassigned'
,
default_label:
'Unassigned'
,
'max-select'
:
1
,
'max-select'
:
1
,
'dropdown-header'
:
'Assignee'
,
'dropdown-header'
:
'Assignee'
,
...
...
app/models/concerns/issuable.rb
View file @
bb0884b0
...
@@ -109,13 +109,6 @@ module Issuable
...
@@ -109,13 +109,6 @@ module Issuable
def
allows_multiple_assignees?
def
allows_multiple_assignees?
false
false
end
end
<<<<<<<
HEAD
def
has_multiple_assignees?
assignees
.
count
>
1
end
=======
>>>>>>>
upstream
/
master
end
end
module
ClassMethods
module
ClassMethods
...
...
app/services/quick_actions/interpret_service.rb
View file @
bb0884b0
...
@@ -137,43 +137,6 @@ module QuickActions
...
@@ -137,43 +137,6 @@ module QuickActions
parse_params
do
|
unassign_param
|
parse_params
do
|
unassign_param
|
# When multiple users are assigned, all will be unassigned if multiple assignees are no longer allowed
# When multiple users are assigned, all will be unassigned if multiple assignees are no longer allowed
extract_users
(
unassign_param
)
if
issuable
.
allows_multiple_assignees?
extract_users
(
unassign_param
)
if
issuable
.
allows_multiple_assignees?
<<<<<<<
HEAD
end
command
:unassign
do
|
users
=
nil
|
@updates
[
:assignee_ids
]
=
if
users
&
.
any?
issuable
.
assignees
.
pluck
(
:id
)
-
users
.
map
(
&
:id
)
else
[]
end
end
desc
do
"Change assignee
#{
'(s)'
if
issuable
.
allows_multiple_assignees?
}
"
end
explanation
do
|
users
|
users
=
issuable
.
allows_multiple_assignees?
?
users
:
users
.
take
(
1
)
"Change
#{
'assignee'
.
pluralize
(
users
.
size
)
}
to
#{
users
.
map
(
&
:to_reference
).
to_sentence
}
."
end
params
do
issuable
.
allows_multiple_assignees?
?
'@user1 @user2'
:
'@user'
end
condition
do
issuable
.
persisted?
&&
current_user
.
can?
(
:"admin_
#{
issuable
.
to_ability_name
}
"
,
project
)
end
parse_params
do
|
assignee_param
|
extract_users
(
assignee_param
)
end
command
:reassign
do
|
users
|
@updates
[
:assignee_ids
]
=
if
issuable
.
allows_multiple_assignees?
users
.
map
(
&
:id
)
else
[
users
.
last
.
id
]
end
=======
>>>>>>>
upstream
/
master
end
end
command
:unassign
do
|
users
=
nil
|
command
:unassign
do
|
users
=
nil
|
@updates
[
:assignee_ids
]
=
@updates
[
:assignee_ids
]
=
...
...
app/views/shared/issuable/_sidebar_assignees.html.haml
View file @
bb0884b0
...
@@ -50,11 +50,7 @@
...
@@ -50,11 +50,7 @@
-
data
[
:multi_select
]
=
true
-
data
[
:multi_select
]
=
true
-
data
[
'dropdown-title'
]
=
title
-
data
[
'dropdown-title'
]
=
title
-
data
[
'dropdown-header'
]
=
dropdown_options
[
:data
][
:'dropdown-header'
]
-
data
[
'dropdown-header'
]
=
dropdown_options
[
:data
][
:'dropdown-header'
]
<
<<<<<<
HEAD
-
data
[
'max-select'
]
=
dropdown_options
[
:data
][
:'max-select'
]
==
=====
-
data
[
'max-select'
]
=
dropdown_options
[
:data
][
:'max-select'
]
if
dropdown_options
[
:data
][
:'max-select'
]
-
data
[
'max-select'
]
=
dropdown_options
[
:data
][
:'max-select'
]
if
dropdown_options
[
:data
][
:'max-select'
]
>
>>>>>> upstream/master
-
options
[
:data
].
merge!
(
data
)
-
options
[
:data
].
merge!
(
data
)
=
dropdown_tag
(
title
,
options:
options
)
=
dropdown_tag
(
title
,
options:
options
)
spec/features/issues/form_spec.rb
View file @
bb0884b0
...
@@ -32,13 +32,8 @@ describe 'New/edit issue', :feature, :js do
...
@@ -32,13 +32,8 @@ describe 'New/edit issue', :feature, :js do
# the original method, resulting in infinite recurison when called.
# the original method, resulting in infinite recurison when called.
# This is likely a bug with helper modules included into dynamically generated view classes.
# This is likely a bug with helper modules included into dynamically generated view classes.
# To work around this, we have to hold on to and call to the original implementation manually.
# To work around this, we have to hold on to and call to the original implementation manually.
<<<<<<<
HEAD
original_issue_dropdown_options
=
FormHelper
.
instance_method
(
:issue_assignees_dropdown_options
)
allow_any_instance_of
(
FormHelper
).
to
receive
(
:issue_assignees_dropdown_options
).
and_wrap_original
do
|
original
,
*
args
|
=======
original_issue_dropdown_options
=
EE
::
FormHelper
.
instance_method
(
:issue_assignees_dropdown_options
)
original_issue_dropdown_options
=
EE
::
FormHelper
.
instance_method
(
:issue_assignees_dropdown_options
)
allow_any_instance_of
(
EE
::
FormHelper
).
to
receive
(
:issue_assignees_dropdown_options
).
and_wrap_original
do
|
original
,
*
args
|
allow_any_instance_of
(
EE
::
FormHelper
).
to
receive
(
:issue_assignees_dropdown_options
).
and_wrap_original
do
|
original
,
*
args
|
>>>>>>>
upstream
/
master
options
=
original_issue_dropdown_options
.
bind
(
original
.
receiver
).
call
(
*
args
)
options
=
original_issue_dropdown_options
.
bind
(
original
.
receiver
).
call
(
*
args
)
options
[
:data
][
:per_page
]
=
2
options
[
:data
][
:per_page
]
=
2
...
...
spec/services/quick_actions/interpret_service_spec.rb
View file @
bb0884b0
...
@@ -469,25 +469,6 @@ describe QuickActions::InterpretService, services: true do
...
@@ -469,25 +469,6 @@ describe QuickActions::InterpretService, services: true do
_
,
updates
=
service
.
execute
(
content
,
merge_request
)
_
,
updates
=
service
.
execute
(
content
,
merge_request
)
expect
(
updates
).
to
eq
(
assignee_ids:
[])
expect
(
updates
).
to
eq
(
assignee_ids:
[])
<<<<<<<
HEAD
end
end
end
context
'reassign command'
do
let
(
:content
)
{
'/reassign'
}
context
'Issue'
do
it
'reassigns user if content contains /reassign @user'
do
user
=
create
(
:user
)
issue
.
update
(
assignee_ids:
[
developer
.
id
])
_
,
updates
=
service
.
execute
(
"/reassign @
#{
user
.
username
}
"
,
issue
)
expect
(
updates
).
to
eq
(
assignee_ids:
[
user
.
id
])
=======
>>>>>>>
upstream
/
master
end
end
end
end
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment