Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
bb747cbb
Commit
bb747cbb
authored
May 19, 2020
by
Paul Slaughter
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Move IDE left sidebar init width to constant
**Why?** - Helps encapsulate this magic number
parent
949d8766
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
12 additions
and
3 deletions
+12
-3
app/assets/javascripts/ide/components/ide_side_bar.vue
app/assets/javascripts/ide/components/ide_side_bar.vue
+7
-2
app/assets/javascripts/ide/components/resizable_panel.vue
app/assets/javascripts/ide/components/resizable_panel.vue
+2
-1
app/assets/javascripts/ide/constants.js
app/assets/javascripts/ide/constants.js
+3
-0
No files found.
app/assets/javascripts/ide/components/ide_side_bar.vue
View file @
bb747cbb
...
...
@@ -9,7 +9,7 @@ import CommitForm from './commit_sidebar/form.vue';
import
IdeReview
from
'
./ide_review.vue
'
;
import
SuccessMessage
from
'
./commit_sidebar/success_message.vue
'
;
import
IdeProjectHeader
from
'
./ide_project_header.vue
'
;
import
{
leftSidebarViews
}
from
'
../constants
'
;
import
{
leftSidebarViews
,
LEFT_SIDEBAR_INIT_WIDTH
}
from
'
../constants
'
;
export
default
{
components
:
{
...
...
@@ -33,11 +33,16 @@ export default {
);
},
},
LEFT_SIDEBAR_INIT_WIDTH
,
};
</
script
>
<
template
>
<resizable-panel
:initial-width=
"340"
side=
"left"
class=
"multi-file-commit-panel flex-column"
>
<resizable-panel
:initial-width=
"$options.LEFT_SIDEBAR_INIT_WIDTH"
side=
"left"
class=
"multi-file-commit-panel flex-column"
>
<template
v-if=
"loading"
>
<div
class=
"multi-file-commit-panel-inner"
>
<div
v-for=
"n in 3"
:key=
"n"
class=
"multi-file-loading-container"
>
...
...
app/assets/javascripts/ide/components/resizable_panel.vue
View file @
bb747cbb
<
script
>
import
{
mapActions
}
from
'
vuex
'
;
import
PanelResizer
from
'
~/vue_shared/components/panel_resizer.vue
'
;
import
{
DEFAULT_SIDEBAR_MIN_WIDTH
}
from
'
../constants
'
;
export
default
{
components
:
{
...
...
@@ -14,7 +15,7 @@ export default {
minSize
:
{
type
:
Number
,
required
:
false
,
default
:
340
,
default
:
DEFAULT_SIDEBAR_MIN_WIDTH
,
},
side
:
{
type
:
String
,
...
...
app/assets/javascripts/ide/constants.js
View file @
bb747cbb
...
...
@@ -4,6 +4,9 @@ export const MAX_WINDOW_HEIGHT_COMPACT = 750;
export
const
MAX_TITLE_LENGTH
=
50
;
export
const
MAX_BODY_LENGTH
=
72
;
export
const
LEFT_SIDEBAR_INIT_WIDTH
=
340
;
export
const
DEFAULT_SIDEBAR_MIN_WIDTH
=
340
;
// File view modes
export
const
FILE_VIEW_MODE_EDITOR
=
'
editor
'
;
export
const
FILE_VIEW_MODE_PREVIEW
=
'
preview
'
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment