Merge branch 'id-remve-find-tag-via-gitaly-ff' into 'master'

Remove find_tag_via_gitaly feature flag

See merge request gitlab-org/gitlab!77303

app/models/repository.rb

@@ -191,7 +191,7 @@ class Repository
   end
 
   def find_tag(name)
-    if @tags.blank? && Feature.enabled?(:find_tag_via_gitaly, project, default_enabled: :yaml)
+    if @tags.blank?
       raw_repository.find_tag(name)
     else
       tags.find { |tag| tag.name == name }

config/feature_flags/development/find_tag_via_gitaly.yml

----
-name: find_tag_via_gitaly
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/70181
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/340899
-milestone: '14.3'
-type: development
-group: group::source code
-default_enabled: true

spec/models/repository_spec.rb

@@ -2398,17 +2398,6 @@ RSpec.describe Repository do
     it 'returns nil when tag does not exists' do
       expect(repository.find_tag('does-not-exist')).to be_nil
     end
-
-    context 'when find_tag_via_gitaly is disabled' do
-      it 'fetches all tags' do
-        stub_feature_flags(find_tag_via_gitaly: false)
-
-        expect(Gitlab::GitalyClient)
-          .to receive(:call).with(anything, :ref_service, :find_all_tags, anything, anything).and_call_original
-
-        expect(repository.find_tag('v1.1.0').name).to eq('v1.1.0')
-      end
-    end
   end
 
   describe '#avatar' do