Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
bc7ef8e5
Commit
bc7ef8e5
authored
Dec 29, 2015
by
Gabriel Mazetto
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add ldap_blocked as new state to users state machine
parent
7403df6c
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
39 additions
and
17 deletions
+39
-17
app/models/user.rb
app/models/user.rb
+11
-1
spec/models/user_spec.rb
spec/models/user_spec.rb
+28
-16
No files found.
app/models/user.rb
View file @
bc7ef8e5
...
@@ -198,16 +198,26 @@ class User < ActiveRecord::Base
...
@@ -198,16 +198,26 @@ class User < ActiveRecord::Base
transition
active: :blocked
transition
active: :blocked
end
end
event
:ldap_block
do
transition
active: :ldap_blocked
end
event
:activate
do
event
:activate
do
transition
blocked: :active
transition
blocked: :active
end
end
state
:blocked
,
:ldap_blocked
do
def
blocked?
true
end
end
end
end
mount_uploader
:avatar
,
AvatarUploader
mount_uploader
:avatar
,
AvatarUploader
# Scopes
# Scopes
scope
:admins
,
->
{
where
(
admin:
true
)
}
scope
:admins
,
->
{
where
(
admin:
true
)
}
scope
:blocked
,
->
{
with_state
(
:
blocked
)
}
scope
:blocked
,
->
{
with_state
s
(
:blocked
,
:ldap_
blocked
)
}
scope
:active
,
->
{
with_state
(
:active
)
}
scope
:active
,
->
{
with_state
(
:active
)
}
scope
:not_in_project
,
->
(
project
)
{
project
.
users
.
present?
?
where
(
"id not in (:ids)"
,
ids:
project
.
users
.
map
(
&
:id
)
)
:
all
}
scope
:not_in_project
,
->
(
project
)
{
project
.
users
.
present?
?
where
(
"id not in (:ids)"
,
ids:
project
.
users
.
map
(
&
:id
)
)
:
all
}
scope
:without_projects
,
->
{
where
(
'id NOT IN (SELECT DISTINCT(user_id) FROM members)'
)
}
scope
:without_projects
,
->
{
where
(
'id NOT IN (SELECT DISTINCT(user_id) FROM members)'
)
}
...
...
spec/models/user_spec.rb
View file @
bc7ef8e5
...
@@ -569,27 +569,39 @@ describe User, models: true do
...
@@ -569,27 +569,39 @@ describe User, models: true do
end
end
end
end
describe
:ldap_user?
do
context
'ldap synchronized user'
do
it
"is true if provider name starts with ldap"
do
describe
:ldap_user?
do
user
=
create
(
:omniauth_user
,
provider:
'ldapmain'
)
it
'is true if provider name starts with ldap'
do
expect
(
user
.
ldap_user?
).
to
be_truthy
user
=
create
(
:omniauth_user
,
provider:
'ldapmain'
)
end
expect
(
user
.
ldap_user?
).
to
be_truthy
end
it
"is false for other providers"
do
it
'is false for other providers'
do
user
=
create
(
:omniauth_user
,
provider:
'other-provider'
)
user
=
create
(
:omniauth_user
,
provider:
'other-provider'
)
expect
(
user
.
ldap_user?
).
to
be_falsey
expect
(
user
.
ldap_user?
).
to
be_falsey
end
it
'is false if no extern_uid is provided'
do
user
=
create
(
:omniauth_user
,
extern_uid:
nil
)
expect
(
user
.
ldap_user?
).
to
be_falsey
end
end
end
it
"is false if no extern_uid is provided"
do
describe
:ldap_identity
do
user
=
create
(
:omniauth_user
,
extern_uid:
nil
)
it
'returns ldap identity'
do
expect
(
user
.
ldap_user?
).
to
be_falsey
user
=
create
:omniauth_user
expect
(
user
.
ldap_identity
.
provider
).
not_to
be_empty
end
end
end
end
describe
:ldap_identity
do
describe
'#ldap_block'
do
it
"returns ldap identity"
do
let
(
:user
)
{
create
(
:omniauth_user
,
provider:
'ldapmain'
,
name:
'John Smith'
)
}
user
=
create
:omniauth_user
expect
(
user
.
ldap_identity
.
provider
).
not_to
be_empty
it
'blocks user flaging the action caming from ldap'
do
user
.
ldap_block
expect
(
user
.
blocked?
).
to
be_truthy
expect
(
user
.
ldap_blocked?
).
to
be_truthy
end
end
end
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment