Merge branch 'leaky-constant-fix-29' into 'master'

Fix leaky constant in sidekiq middleware client metric specs

See merge request gitlab-org/gitlab!32108

.rubocop.yml

@@ -365,7 +365,6 @@ RSpec/LeakyConstantDeclaration:
     - 'spec/lib/gitlab/no_cache_headers_spec.rb'
     - 'spec/lib/gitlab/path_regex_spec.rb'
     - 'spec/lib/gitlab/quick_actions/dsl_spec.rb'
-    - 'spec/lib/gitlab/sidekiq_middleware/client_metrics_spec.rb'
     - 'spec/lib/gitlab/sidekiq_middleware/server_metrics_spec.rb'
     - 'spec/lib/marginalia_spec.rb'
     - 'spec/mailers/notify_spec.rb'

changelogs/unreleased/leaky-constant-fix-29.yml

+---
+title: Fix leaky constant issue in sidekiq middleware client metric spec
+merge_request: 32108
+author: Rajendra Kadam
+type: fixed

spec/lib/gitlab/sidekiq_middleware/client_metrics_spec.rb

@@ -47,9 +47,12 @@ describe Gitlab::SidekiqMiddleware::ClientMetrics do
     end
 
     context "when workers are not attributed" do
-      class TestNonAttributedWorker
+      before do
+        stub_const('TestNonAttributedWorker', Class.new)
+        TestNonAttributedWorker.class_eval do
           include Sidekiq::Worker
         end
+      end
 
       it_behaves_like "a metrics client middleware" do
         let(:worker) { TestNonAttributedWorker.new }