Commit bfcaba70 authored by Jose Vargas's avatar Jose Vargas

Change specs to reflect the new dashboard order

parent 7c2b7f70
...@@ -69,7 +69,7 @@ describe('Time series component', () => { ...@@ -69,7 +69,7 @@ describe('Time series component', () => {
mockedQueryResultFixture, mockedQueryResultFixture,
); );
// dashboard is a dynamically generated fixture and stored at environment_metrics_dashboard.json // dashboard is a dynamically generated fixture and stored at environment_metrics_dashboard.json
[mockGraphData] = store.state.monitoringDashboard.dashboard.panelGroups[0].panels; [mockGraphData] = store.state.monitoringDashboard.dashboard.panelGroups[1].panels;
}); });
describe('general functions', () => { describe('general functions', () => {
......
...@@ -89,8 +89,8 @@ describe('Monitoring store Getters', () => { ...@@ -89,8 +89,8 @@ describe('Monitoring store Getters', () => {
expect(getMetricStates()).toEqual([metricStates.OK]); expect(getMetricStates()).toEqual([metricStates.OK]);
// Filtered by groups // Filtered by groups
expect(getMetricStates(state.dashboard.panelGroups[0].key)).toEqual([metricStates.OK]); expect(getMetricStates(state.dashboard.panelGroups[1].key)).toEqual([metricStates.OK]);
expect(getMetricStates(state.dashboard.panelGroups[1].key)).toEqual([]); expect(getMetricStates(state.dashboard.panelGroups[2].key)).toEqual([]);
}); });
it('on multiple metrics errors', () => { it('on multiple metrics errors', () => {
mutations[types.RECEIVE_METRICS_DATA_SUCCESS](state, metricsDashboardPayload); mutations[types.RECEIVE_METRICS_DATA_SUCCESS](state, metricsDashboardPayload);
...@@ -118,18 +118,18 @@ describe('Monitoring store Getters', () => { ...@@ -118,18 +118,18 @@ describe('Monitoring store Getters', () => {
mutations[types.RECEIVE_METRIC_RESULT_SUCCESS](state, mockedQueryResultFixture); mutations[types.RECEIVE_METRIC_RESULT_SUCCESS](state, mockedQueryResultFixture);
// An error in 2 groups // An error in 2 groups
mutations[types.RECEIVE_METRIC_RESULT_FAILURE](state, { mutations[types.RECEIVE_METRIC_RESULT_FAILURE](state, {
metricId: groups[0].panels[1].metrics[0].metricId, metricId: groups[1].panels[1].metrics[0].metricId,
}); });
mutations[types.RECEIVE_METRIC_RESULT_FAILURE](state, { mutations[types.RECEIVE_METRIC_RESULT_FAILURE](state, {
metricId: groups[1].panels[0].metrics[0].metricId, metricId: groups[2].panels[0].metrics[0].metricId,
}); });
expect(getMetricStates()).toEqual([metricStates.OK, metricStates.UNKNOWN_ERROR]); expect(getMetricStates()).toEqual([metricStates.OK, metricStates.UNKNOWN_ERROR]);
expect(getMetricStates(groups[0].key)).toEqual([ expect(getMetricStates(groups[1].key)).toEqual([
metricStates.OK, metricStates.OK,
metricStates.UNKNOWN_ERROR, metricStates.UNKNOWN_ERROR,
]); ]);
expect(getMetricStates(groups[1].key)).toEqual([metricStates.UNKNOWN_ERROR]); expect(getMetricStates(groups[2].key)).toEqual([metricStates.UNKNOWN_ERROR]);
}); });
}); });
}); });
...@@ -210,13 +210,13 @@ describe('Monitoring store Getters', () => { ...@@ -210,13 +210,13 @@ describe('Monitoring store Getters', () => {
mutations[types.RECEIVE_METRIC_RESULT_SUCCESS](state, mockedQueryResultFixtureStatusCode); mutations[types.RECEIVE_METRIC_RESULT_SUCCESS](state, mockedQueryResultFixtureStatusCode);
// First group has metrics // First group has metrics
expect(metricsWithData(state.dashboard.panelGroups[0].key)).toEqual([ expect(metricsWithData(state.dashboard.panelGroups[1].key)).toEqual([
mockedQueryResultFixture.metricId, mockedQueryResultFixture.metricId,
mockedQueryResultFixtureStatusCode.metricId, mockedQueryResultFixtureStatusCode.metricId,
]); ]);
// Second group has no metrics // Second group has no metrics
expect(metricsWithData(state.dashboard.panelGroups[1].key)).toEqual([]); expect(metricsWithData(state.dashboard.panelGroups[2].key)).toEqual([]);
}); });
}); });
}); });
......
...@@ -32,12 +32,13 @@ describe('Monitoring mutations', () => { ...@@ -32,12 +32,13 @@ describe('Monitoring mutations', () => {
mutations[types.RECEIVE_METRICS_DATA_SUCCESS](stateCopy, payload); mutations[types.RECEIVE_METRICS_DATA_SUCCESS](stateCopy, payload);
const groups = getGroups(); const groups = getGroups();
expect(groups[0].key).toBe('response-metrics-nginx-ingress-vts-0'); expect(groups[0].key).toBe('system-metrics-kubernetes-0');
expect(groups[1].key).toBe('response-metrics-nginx-ingress-1'); expect(groups[1].key).toBe('response-metrics-nginx-ingress-vts-1');
expect(groups[2].key).toBe('response-metrics-nginx-ingress-2');
}); });
it('normalizes values', () => { it('normalizes values', () => {
mutations[types.RECEIVE_METRICS_DATA_SUCCESS](stateCopy, payload); mutations[types.RECEIVE_METRICS_DATA_SUCCESS](stateCopy, payload);
const expectedLabel = '5xx Errors (%)'; const expectedLabel = 'Pod average (MB)';
const { label, queryRange } = getGroups()[0].panels[2].metrics[0]; const { label, queryRange } = getGroups()[0].panels[2].metrics[0];
expect(label).toEqual(expectedLabel); expect(label).toEqual(expectedLabel);
...@@ -51,7 +52,7 @@ describe('Monitoring mutations', () => { ...@@ -51,7 +52,7 @@ describe('Monitoring mutations', () => {
expect(groups).toBeDefined(); expect(groups).toBeDefined();
expect(groups).toHaveLength(6); expect(groups).toHaveLength(6);
expect(groups[0].panels).toHaveLength(3); expect(groups[0].panels).toHaveLength(7);
expect(groups[0].panels[0].metrics).toHaveLength(1); expect(groups[0].panels[0].metrics).toHaveLength(1);
expect(groups[0].panels[1].metrics).toHaveLength(1); expect(groups[0].panels[1].metrics).toHaveLength(1);
expect(groups[0].panels[2].metrics).toHaveLength(1); expect(groups[0].panels[2].metrics).toHaveLength(1);
...@@ -65,9 +66,12 @@ describe('Monitoring mutations', () => { ...@@ -65,9 +66,12 @@ describe('Monitoring mutations', () => {
const groups = getGroups(); const groups = getGroups();
expect(groups[0].panels[0].metrics[0].metricId).toEqual( expect(groups[0].panels[0].metrics[0].metricId).toEqual(
'undefined_response_metrics_nginx_ingress_throughput_status_code', 'undefined_system_metrics_kubernetes_container_memory_total',
); );
expect(groups[1].panels[0].metrics[0].metricId).toEqual( expect(groups[1].panels[0].metrics[0].metricId).toEqual(
'undefined_response_metrics_nginx_ingress_throughput_status_code',
);
expect(groups[2].panels[0].metrics[0].metricId).toEqual(
'undefined_response_metrics_nginx_ingress_16_throughput_status_code', 'undefined_response_metrics_nginx_ingress_16_throughput_status_code',
); );
}); });
...@@ -135,7 +139,7 @@ describe('Monitoring mutations', () => { ...@@ -135,7 +139,7 @@ describe('Monitoring mutations', () => {
}, },
]; ];
const dashboard = metricsDashboardPayload; const dashboard = metricsDashboardPayload;
const getMetric = () => stateCopy.dashboard.panelGroups[0].panels[0].metrics[0]; const getMetric = () => stateCopy.dashboard.panelGroups[1].panels[0].metrics[0];
describe('REQUEST_METRIC_RESULT', () => { describe('REQUEST_METRIC_RESULT', () => {
beforeEach(() => { beforeEach(() => {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment