Merge branch 'pedropombeiro/pvs-correlation-header-name' into 'master'

Use X-Gitlab-Correlation-Id header name for PVS

See merge request gitlab-org/gitlab!59634

lib/gitlab/ci/pipeline/chain/validate/external.rb

@@ -70,7 +70,7 @@ module Gitlab
 
             def validate_service_request
               headers = {
-                'X-Request-ID' => Labkit::Correlation::CorrelationId.current_id,
+                'X-Gitlab-Correlation-id' => Labkit::Correlation::CorrelationId.current_id,
                 'X-Gitlab-Token' => validation_service_token
               }.compact
 

spec/lib/gitlab/ci/pipeline/chain/validate/external_spec.rb

@@ -88,7 +88,7 @@ RSpec.describe Gitlab::Ci::Pipeline::Chain::Validate::External do
       expect(::Gitlab::HTTP).to receive(:post) do |_url, params|
         expect(params[:body]).to match_schema('/external_validation')
         expect(params[:timeout]).to eq(described_class::DEFAULT_VALIDATION_REQUEST_TIMEOUT)
-        expect(params[:headers]).to eq({ 'X-Request-ID' => 'correlation-id' })
+        expect(params[:headers]).to eq({ 'X-Gitlab-Correlation-id' => 'correlation-id' })
       end
 
       perform!