Merge branch 'update-label-types' into 'master'

Initial tooling docs and danger changes

See merge request gitlab-org/gitlab!82056

.gitlab/issue_templates/Refactoring.md

@@ -42,8 +42,9 @@ please list them here.
 Please select the appropriate label from the following:
     ~"feature::addition"
     ~"type::maintenance"
-    ~"tooling::pipelines"
-    ~"tooling::workflow"
+    ~"maintenance::refactor"
+    ~"maintenance::pipelines"
+    ~"maintenance::workflow"
 -->
 
 /label ~"type::maintenance"

.gitlab/merge_request_templates/Pipeline Configuration.md

@@ -35,4 +35,4 @@ This will help keep track of expected cost increases to the [GitLab project aver
 
 - [ ] Consider communicating these changes to the broader team following the [communication guideline for pipeline changes](https://about.gitlab.com/handbook/engineering/quality/engineering-productivity/#pipeline-changes)
 
-/label ~"type::tooling" ~"tooling::pipelines" ~"Engineering Productivity"
+/label ~"maintenance::pipelines" ~"Engineering Productivity"

danger/specialization_labels/Dangerfile

@@ -9,7 +9,6 @@ SPECIALIZATIONS = {
   ux: 'UX',
   docs: 'documentation',
   qa: 'QA',
-  tooling: 'type::tooling',
   ci_template: 'ci::templates',
   feature_flag: 'feature flag'
 }.freeze

danger/specs/Dangerfile

 # frozen_string_literal: true
 
 NO_SPECS_LABELS = [
-  'type::tooling',
-  'tooling::pipelines',
-  'tooling::workflow',
+  'maintenance::pipelines',
+  'maintenance::workflow',
   'documentation',
   'QA'
 ].freeze

doc/development/contributing/issue_workflow.md

@@ -45,7 +45,7 @@ scheduling into milestones. Labeling is a task for everyone. (For some projects,
 
 Most issues will have labels for at least one of the following:
 
-- Type. For example: `~"type::feature"`, `~"type::bug"`, or `~"type::tooling"`.
+- Type. For example: `~"type::feature"`, `~"type::bug"`, or `~"type::maintenance"`.
 - Stage. For example: `~"devops::plan"` or `~"devops::create"`.
 - Group. For example: `~"group::source code"`, `~"group::knowledge"`, or `~"group::editor"`.
 - Category. For example: `~"Category:Code Analytics"`, `~"Category:DevOps Reports"`, or `~"Category:Templates"`.
@@ -72,19 +72,7 @@ labels, you can _always_ add the type, stage, group, and often the category/feat
 Type labels are very important. They define what kind of issue this is. Every
 issue should have one and only one.
 
-The current type labels are:
-
-- `~"type::feature"`
-  - `~"feature::addition"`
-  - `~"feature::enhancement"`
-- `~"type::maintenance"`
-- `~"type::bug"`
-- `~"type::tooling"`
-  - `~"tooling::pipelines"`
-  - `~"tooling::workflow"`
-- `~"support request"`
-- `~meta`
-- `~documentation`
+The current type labels are [available in the handbook](https://about.gitlab.com/handbook/engineering/metrics/#work-type-classification)
 
 A number of type labels have a priority assigned to them, which automatically
 makes them float to the top, depending on their importance.

spec/tooling/danger/datateam_spec.rb

@@ -62,28 +62,28 @@ RSpec.describe Tooling::Danger::Datateam do
         'with metric file changes and no performance indicator changes and other label' => {
           modified_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml),
           changed_lines: ['-product_stage: growth'],
-          mr_labels: ['type::tooling'],
+          mr_labels: ['type::maintenance'],
           impacted: false,
           impacted_files: []
         },
         'with performance indicator changes and other label' => {
           modified_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml app/models/user.rb),
           changed_lines: ['+-gmau'],
-          mr_labels: ['type::tooling'],
+          mr_labels: ['type::maintenance'],
           impacted: true,
           impacted_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml)
         },
         'with performance indicator changes, Data Warehouse::Impact Check and other label' => {
           modified_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml app/models/user.rb),
           changed_lines: ['+-gmau'],
-          mr_labels: ['type::tooling', 'Data Warehouse::Impact Check'],
+          mr_labels: ['type::maintenance', 'Data Warehouse::Impact Check'],
           impacted: false,
           impacted_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml)
         },
         'with performance indicator changes and other labels' => {
           modified_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml app/models/user.rb),
           changed_lines: ['+-gmau'],
-          mr_labels: ['type::tooling', 'Data Warehouse::Impacted'],
+          mr_labels: ['type::maintenance', 'Data Warehouse::Impacted'],
           impacted: false,
           impacted_files: %w(config/metrics/20210216182127_user_secret_detection_jobs.yml)
         }