Merge branch 'issue#325836-fix-empty-line-after-let-it-be-gitlab-alert-management' into 'master'

Fix EmptyLineAfterFinalLetItBe offenses in spec/lib/gitlab/alert_management

See merge request gitlab-org/gitlab!58244

.rubocop_manual_todo.yml

@@ -786,12 +786,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
     - spec/lib/bulk_imports/groups/loaders/group_loader_spec.rb
     - spec/lib/extracts_path_spec.rb
     - spec/lib/extracts_ref_spec.rb
-    - spec/lib/gitlab/alert_management/alert_status_counts_spec.rb
-    - spec/lib/gitlab/alert_management/payload/base_spec.rb
-    - spec/lib/gitlab/alert_management/payload/generic_spec.rb
-    - spec/lib/gitlab/alert_management/payload/managed_prometheus_spec.rb
-    - spec/lib/gitlab/alert_management/payload/prometheus_spec.rb
-    - spec/lib/gitlab/alert_management/payload_spec.rb
     - spec/lib/gitlab/auth/otp/strategies/devise_spec.rb
     - spec/lib/gitlab/auth/otp/strategies/forti_authenticator_spec.rb
     - spec/lib/gitlab/auth/otp/strategies/forti_token_cloud_spec.rb

changelogs/unreleased/issue-325836-fix-empty-line-after-let-it-be-gitlab-alert-management.yml

+---
+title: Fix EmptyLineAfterFinalLetItBe in spec/lib/gitlab/alert_management
+merge_request: 58244
+author: Huzaifa Iftikhar @huzaifaiftikhar
+type: fixed

spec/lib/gitlab/alert_management/alert_status_counts_spec.rb

@@ -8,6 +8,7 @@ RSpec.describe Gitlab::AlertManagement::AlertStatusCounts do
   let_it_be(:alert_resolved) { create(:alert_management_alert, :resolved, project: project) }
   let_it_be(:alert_ignored) { create(:alert_management_alert, :ignored, project: project) }
   let_it_be(:alert_triggered) { create(:alert_management_alert) }
+
   let(:params) { {} }
 
   describe '#execute' do

spec/lib/gitlab/alert_management/payload/base_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe Gitlab::AlertManagement::Payload::Base do
   let_it_be(:project) { create(:project) }
+
   let(:raw_payload) { {} }
   let(:payload_class) { described_class }
 

spec/lib/gitlab/alert_management/payload/generic_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe Gitlab::AlertManagement::Payload::Generic do
   let_it_be(:project) { build_stubbed(:project) }
+
   let(:raw_payload) { {} }
 
   let(:parsed_payload) { described_class.new(project: project, payload: raw_payload) }

spec/lib/gitlab/alert_management/payload/managed_prometheus_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe Gitlab::AlertManagement::Payload::ManagedPrometheus do
   let_it_be(:project) { create(:project) }
+
   let(:raw_payload) { {} }
 
   let(:parsed_payload) { described_class.new(project: project, payload: raw_payload) }
@@ -136,6 +137,7 @@ RSpec.describe Gitlab::AlertManagement::Payload::ManagedPrometheus do
 
     context 'with sufficient fallback info' do
       let_it_be(:environment) { create(:environment, project: project, name: 'production') }
+
       let(:raw_payload) do
         {
           'labels' => {

spec/lib/gitlab/alert_management/payload/prometheus_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe Gitlab::AlertManagement::Payload::Prometheus do
   let_it_be(:project) { create(:project) }
+
   let(:raw_payload) { {} }
 
   let(:parsed_payload) { described_class.new(project: project, payload: raw_payload) }

spec/lib/gitlab/alert_management/payload_spec.rb

@@ -5,6 +5,7 @@ require 'spec_helper'
 RSpec.describe Gitlab::AlertManagement::Payload do
   describe '#parse' do
     let_it_be(:project) { build_stubbed(:project) }
+
     let(:payload) { {} }
 
     context 'without a monitoring_tool specified by caller' do