Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
c48818a3
Commit
c48818a3
authored
Nov 07, 2018
by
Dmitriy Zaporozhets
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add specs and changelog for packages fix
Signed-off-by:
Dmitriy Zaporozhets
<
dmitriy.zaporozhets@gmail.com
>
parent
56bcc27b
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
28 additions
and
5 deletions
+28
-5
ee/changelogs/unreleased/8316-maven-package-permissions-option-wrongly-available-in-starter.yml
...ckage-permissions-option-wrongly-available-in-starter.yml
+5
-0
ee/spec/features/projects/settings/packages_settings_spec.rb
ee/spec/features/projects/settings/packages_settings_spec.rb
+22
-4
spec/features/projects/features_visibility_spec.rb
spec/features/projects/features_visibility_spec.rb
+1
-1
No files found.
ee/changelogs/unreleased/8316-maven-package-permissions-option-wrongly-available-in-starter.yml
0 → 100644
View file @
c48818a3
---
title
:
Don't show packages tab and settings for starter license
merge_request
:
8270
author
:
type
:
fixed
ee/spec/features/projects/settings/packages_settings_spec.rb
View file @
c48818a3
...
@@ -14,11 +14,29 @@ describe 'Projects > Settings > Packages', :js do
...
@@ -14,11 +14,29 @@ describe 'Projects > Settings > Packages', :js do
allow
(
Gitlab
.
config
.
packages
).
to
receive
(
:enabled
).
and_return
(
true
)
allow
(
Gitlab
.
config
.
packages
).
to
receive
(
:enabled
).
and_return
(
true
)
end
end
it
'displays the packages toggle button'
do
context
'allowed by license'
do
visit
edit_project_path
(
project
)
before
do
stub_licensed_features
(
packages:
true
)
end
it
'displays the packages toggle button'
do
visit
edit_project_path
(
project
)
expect
(
page
).
to
have_content
(
'Packages'
)
expect
(
page
).
to
have_selector
(
'input[name="project[packages_enabled]"] + button'
,
visible:
true
)
end
end
context
'not allowed by license'
do
before
do
stub_licensed_features
(
packages:
false
)
end
it
'does not show up in UI'
do
visit
edit_project_path
(
project
)
expect
(
page
).
to
have_content
(
'Packages'
)
expect
(
page
).
not_
to
have_content
(
'Packages'
)
e
xpect
(
page
).
to
have_selector
(
'input[name="project[packages_enabled]"] + button'
,
visible:
true
)
e
nd
end
end
end
end
...
...
spec/features/projects/features_visibility_spec.rb
View file @
c48818a3
...
@@ -177,7 +177,7 @@ describe 'Edit Project Settings' do
...
@@ -177,7 +177,7 @@ describe 'Edit Project Settings' do
click_button
"Save changes"
click_button
"Save changes"
end
end
expect
(
find
(
".sharing-permissions"
)).
to
have_selector
(
".project-feature-toggle.is-disabled"
,
count:
3
)
expect
(
find
(
".sharing-permissions"
)).
to
have_selector
(
".project-feature-toggle.is-disabled"
,
count:
2
)
end
end
it
"shows empty features project homepage"
do
it
"shows empty features project homepage"
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment