Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
c4df0fbf
Commit
c4df0fbf
authored
Sep 24, 2020
by
Heinrich Lee Yu
Committed by
Axel García
Sep 24, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add controller and feature specs
Also optimizes the target service so that we don't do a useless query
parent
ff61c5a8
Changes
7
Show whitespace changes
Inline
Side-by-side
Showing
7 changed files
with
182 additions
and
132 deletions
+182
-132
app/services/quick_actions/target_service.rb
app/services/quick_actions/target_service.rb
+4
-0
ee/app/controllers/groups/epics_controller.rb
ee/app/controllers/groups/epics_controller.rb
+3
-1
ee/app/services/ee/quick_actions/target_service.rb
ee/app/services/ee/quick_actions/target_service.rb
+3
-0
ee/app/views/groups/epics/new.html.haml
ee/app/views/groups/epics/new.html.haml
+0
-1
ee/changelogs/unreleased/add-support-for-epic-descriptions-quick-actions-on-epic-creation-form.yml
...epic-descriptions-quick-actions-on-epic-creation-form.yml
+5
-0
ee/spec/controllers/groups/autocomplete_sources_controller_spec.rb
...ontrollers/groups/autocomplete_sources_controller_spec.rb
+12
-0
ee/spec/features/epics/gfm_autocomplete_spec.rb
ee/spec/features/epics/gfm_autocomplete_spec.rb
+155
-130
No files found.
app/services/quick_actions/target_service.rb
View file @
c4df0fbf
...
...
@@ -17,12 +17,16 @@ module QuickActions
# rubocop: disable CodeReuse/ActiveRecord
def
issue
(
type_id
)
return
project
.
issues
.
build
if
type_id
.
nil?
IssuesFinder
.
new
(
current_user
,
project_id:
project
.
id
).
find_by
(
iid:
type_id
)
||
project
.
issues
.
build
end
# rubocop: enable CodeReuse/ActiveRecord
# rubocop: disable CodeReuse/ActiveRecord
def
merge_request
(
type_id
)
return
project
.
merge_requests
.
build
if
type_id
.
nil?
MergeRequestsFinder
.
new
(
current_user
,
project_id:
project
.
id
).
find_by
(
iid:
type_id
)
||
project
.
merge_requests
.
build
end
# rubocop: enable CodeReuse/ActiveRecord
...
...
ee/app/controllers/groups/epics_controller.rb
View file @
c4df0fbf
...
...
@@ -20,7 +20,9 @@ class Groups::EpicsController < Groups::ApplicationController
push_frontend_feature_flag
(
:vue_issuable_epic_sidebar
,
@group
)
end
def
new
;
end
def
new
@noteable
=
Epic
.
new
end
def
index
@epics
=
@issuables
...
...
ee/app/services/ee/quick_actions/target_service.rb
View file @
c4df0fbf
...
...
@@ -14,6 +14,9 @@ module EE
# rubocop: disable CodeReuse/ActiveRecord
def
epic
(
type_id
)
group
=
params
[
:group
]
return
group
.
epics
.
build
if
type_id
.
nil?
EpicsFinder
.
new
(
current_user
,
group_id:
group
.
id
).
find_by
(
iid:
type_id
)
||
group
.
epics
.
build
end
# rubocop: enable CodeReuse/ActiveRecord
...
...
ee/app/views/groups/epics/new.html.haml
View file @
c4df0fbf
-
@gfm_form
=
true
-
@noteable
=
Epic
.
new
-
add_to_breadcrumbs
_
(
"Epics"
),
group_epics_path
(
@group
)
-
breadcrumb_title
_
(
"New"
)
-
page_title
_
(
"New epic"
)
...
...
ee/changelogs/unreleased/add-support-for-epic-descriptions-quick-actions-on-epic-creation-form.yml
0 → 100644
View file @
c4df0fbf
---
title
:
Fix quick actions autocomplete in new epic form
merge_request
:
37099
author
:
type
:
fixed
ee/spec/controllers/groups/autocomplete_sources_controller_spec.rb
View file @
c4df0fbf
...
...
@@ -105,5 +105,17 @@ RSpec.describe Groups::AutocompleteSourcesController do
}
)
end
it
'handles new epics'
do
get
:commands
,
params:
{
group_id:
group
,
type:
'Epic'
,
type_id:
nil
}
expect
(
json_response
).
to
be_an
(
Array
)
expect
(
json_response
).
to
include
(
{
'name'
=>
'cc'
,
'aliases'
=>
[],
'description'
=>
'CC'
,
'params'
=>
[
'@user'
],
'warning'
=>
''
,
'icon'
=>
''
}
)
end
end
end
ee/spec/features/epics/gfm_autocomplete_spec.rb
View file @
c4df0fbf
...
...
@@ -3,15 +3,39 @@
require
'spec_helper'
RSpec
.
describe
'GFM autocomplete'
,
:js
do
let
(
:user
)
{
create
(
:user
,
name:
'💃speciąl someone💃'
,
username:
'someone.special'
)
}
let
(
:group
)
{
create
(
:group
)
}
let
(
:label
)
{
create
(
:group_label
,
group:
group
,
title:
'special+'
)
}
let
(
:epic
)
{
create
(
:epic
,
group:
group
)
}
let_it_be
(
:user
)
{
create
(
:user
,
name:
'💃speciąl someone💃'
,
username:
'someone.special'
)
}
let_it_be
(
:group
)
{
create
(
:group
)
}
let_it_be
(
:epic
)
{
create
(
:epic
,
group:
group
)
}
before_all
do
group
.
add_maintainer
(
user
)
end
before
do
stub_licensed_features
(
epics:
true
)
group
.
add_maintainer
(
user
)
sign_in
(
user
)
end
context
'for a new epic'
do
let_it_be
(
:label
)
{
create
(
:group_label
,
group:
group
)
}
before
do
visit
new_group_epic_path
(
group
)
end
it
'opens quick action autocomplete in the description field'
do
find
(
'#epic-description'
).
native
.
send_keys
(
'/la'
)
expect
(
page
).
to
have_selector
(
'.atwho-container'
)
page
.
within
'.atwho-container #at-view-commands'
do
expect
(
find
(
'li'
,
match: :first
)).
to
have_content
(
'/label'
)
end
end
end
context
'for an existing epic'
do
before
do
visit
group_epic_path
(
group
,
epic
)
wait_for_requests
...
...
@@ -78,9 +102,9 @@ RSpec.describe 'GFM autocomplete', :js do
end
context
'labels'
do
let!
(
:backend
)
{
create
(
:group_label
,
group:
group
,
title:
'backend'
)
}
let!
(
:bug
)
{
create
(
:group_label
,
group:
group
,
title:
'bug'
)
}
let!
(
:feature_proposal
)
{
create
(
:group_label
,
group:
group
,
title:
'feature proposal'
)
}
let_it_be
(
:backend
)
{
create
(
:group_label
,
group:
group
,
title:
'backend'
)
}
let_it_be
(
:bug
)
{
create
(
:group_label
,
group:
group
,
title:
'bug'
)
}
let_it_be
(
:feature_proposal
)
{
create
(
:group_label
,
group:
group
,
title:
'feature proposal'
)
}
context
'when no labels are assigned'
do
it
'shows all labels for ~'
do
...
...
@@ -204,6 +228,7 @@ RSpec.describe 'GFM autocomplete', :js do
end
end
end
end
private
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment