Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
c6527bb3
Commit
c6527bb3
authored
Jan 14, 2020
by
Ryan Cobb
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add tracking for cluster application installs
parent
00d09aab
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
8 additions
and
0 deletions
+8
-0
app/services/clusters/applications/check_installation_progress_service.rb
...sters/applications/check_installation_progress_service.rb
+2
-0
spec/services/clusters/applications/check_installation_progress_service_spec.rb
.../applications/check_installation_progress_service_spec.rb
+6
-0
No files found.
app/services/clusters/applications/check_installation_progress_service.rb
View file @
c6527bb3
...
@@ -11,6 +11,8 @@ module Clusters
...
@@ -11,6 +11,8 @@ module Clusters
def
on_success
def
on_success
app
.
make_installed!
app
.
make_installed!
Gitlab
::
Tracking
.
event
(
'cluster:applications'
,
"cluster_application_
#{
app
.
name
}
_installed"
)
ensure
ensure
remove_installation_pod
remove_installation_pod
end
end
...
...
spec/services/clusters/applications/check_installation_progress_service_spec.rb
View file @
c6527bb3
...
@@ -160,6 +160,12 @@ describe Clusters::Applications::CheckInstallationProgressService, '#execute' do
...
@@ -160,6 +160,12 @@ describe Clusters::Applications::CheckInstallationProgressService, '#execute' do
expect
(
application
).
to
be_installed
expect
(
application
).
to
be_installed
expect
(
application
.
status_reason
).
to
be_nil
expect
(
application
.
status_reason
).
to
be_nil
end
end
it
'tracks application install'
do
expect
(
Gitlab
::
Tracking
).
to
receive
(
:event
).
with
(
'cluster:applications'
,
"cluster_application_helm_installed"
)
service
.
execute
end
end
end
context
'when installation POD failed'
do
context
'when installation POD failed'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment