Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
c899740a
Commit
c899740a
authored
Apr 07, 2021
by
Denys Mishunov
Committed by
Vitaly Slobodin
Apr 07, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Removed "Lists" entry from Requirements nav item [RUN ALL RSPEC] [RUN AS-IF-FOSS]
parent
6af841ba
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
50 additions
and
17 deletions
+50
-17
config/feature_flags/development/project_sidebar_refactor.yml
...ig/feature_flags/development/project_sidebar_refactor.yml
+8
-0
ee/app/views/layouts/nav/_requirements_link.html.haml
ee/app/views/layouts/nav/_requirements_link.html.haml
+9
-8
ee/spec/features/projects/navbar_spec.rb
ee/spec/features/projects/navbar_spec.rb
+33
-9
No files found.
config/feature_flags/development/project_sidebar_refactor.yml
0 → 100644
View file @
c899740a
---
name
:
project_sidebar_refactor
introduced_by_url
:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/58638
rollout_issue_url
:
https://gitlab.com/gitlab-org/gitlab/-/issues/326111
milestone
:
'
13.11'
type
:
development
group
:
group::editor
default_enabled
:
false
ee/app/views/layouts/nav/_requirements_link.html.haml
View file @
c899740a
...
...
@@ -6,11 +6,12 @@
=
sprite_icon
(
'requirements'
)
%span
.nav-item-name
=
_
(
'Requirements'
)
%ul
.sidebar-sub-level-items
=
nav_link
(
path:
'requirements#index'
,
html_options:
{
class:
"fly-out-top-item"
}
)
do
=
link_to
project_requirements_management_requirements_path
(
project
)
do
%strong
.fly-out-top-item-name
=
_
(
'Requirements'
)
%li
.divider.fly-out-top-item
=
nav_link
(
path:
'requirements#index'
,
html_options:
{
class:
'home'
})
do
=
link_to
project_requirements_management_requirements_path
(
project
),
title:
'List'
do
%span
=
_
(
'List'
)
-
if
Feature
.
disabled?
(
:project_sidebar_refactor
)
%ul
.sidebar-sub-level-items
=
nav_link
(
path:
'requirements#index'
,
html_options:
{
class:
"fly-out-top-item"
}
)
do
=
link_to
project_requirements_management_requirements_path
(
project
)
do
%strong
.fly-out-top-item-name
=
_
(
'Requirements'
)
%li
.divider.fly-out-top-item
=
nav_link
(
path:
'requirements#index'
,
html_options:
{
class:
'home'
})
do
=
link_to
project_requirements_management_requirements_path
(
project
),
title:
'List'
do
%span
=
_
(
'List'
)
ee/spec/features/projects/navbar_spec.rb
View file @
c899740a
...
...
@@ -81,18 +81,42 @@ RSpec.describe 'Project navbar' do
context
'when requirements is available'
do
before
do
stub_licensed_features
(
requirements:
true
)
end
insert_after_nav_item
(
_
(
'Merge requests'
),
new_nav_item:
{
nav_item:
_
(
'Requirements'
),
nav_sub_items:
[
_
(
'List'
)]
}
)
context
'with flag enabled'
do
before
do
stub_feature_flags
(
project_sidebar_refactor:
true
)
visit
project_path
(
project
)
insert_after_nav_item
(
_
(
'Merge requests'
),
new_nav_item:
{
nav_item:
_
(
'Requirements'
),
nav_sub_items:
[]
}
)
visit
project_path
(
project
)
end
it_behaves_like
'verified navigation bar'
end
it_behaves_like
'verified navigation bar'
context
'with flag disabled'
do
before
do
stub_feature_flags
(
project_sidebar_refactor:
false
)
insert_after_nav_item
(
_
(
'Merge requests'
),
new_nav_item:
{
nav_item:
_
(
'Requirements'
),
nav_sub_items:
[
_
(
'List'
)]
}
)
visit
project_path
(
project
)
end
it_behaves_like
'verified navigation bar'
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment