Commit cba40c41 authored by Thong Kuah's avatar Thong Kuah

Add how author can resolve "Not blocking:"

parent 17124c07
...@@ -294,8 +294,10 @@ experience, refactors the existing code). Then: ...@@ -294,8 +294,10 @@ experience, refactors the existing code). Then:
- Seek to understand the author's perspective. - Seek to understand the author's perspective.
- If you don't understand a piece of code, _say so_. There's a good chance - If you don't understand a piece of code, _say so_. There's a good chance
someone else would be confused by it as well. someone else would be confused by it as well.
- Do prefix your comment with "Not blocking:" if you have a small, non-mandatory - Do prefix your comment with "Not blocking:" if you have a small,
improvement you wish to suggest. non-mandatory improvement you wish to suggest. This lets the author
know that they can optionally resolve this issue in this merge request
or follow-up at a later stage.
- After a round of line notes, it can be helpful to post a summary note such as - After a round of line notes, it can be helpful to post a summary note such as
"LGTM :thumbsup:", or "Just a couple things to address." "LGTM :thumbsup:", or "Just a couple things to address."
- Assign the merge request to the author if changes are required following your - Assign the merge request to the author if changes are required following your
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment