Skip to content

G
gitlab-ce
Commit cbb42668 authored by Francisco Javier López's avatar Francisco Javier López
Browse files
Options

Improve performance of snippet visibility rspec

parent 6d4eb46b
Hide whitespace changes
Inline Side-by-side
Showing with 200 additions and 186 deletions
spec/support/shared_examples/finders/snippet_visibility_shared_examples.rb
View file @ cbb42668
...@@ -9,13 +9,28 @@ RSpec.shared_examples 'snippet visibility' do ...@@ -9,13 +9,28 @@ RSpec.shared_examples 'snippet visibility' do
let_it_be(:non_member) { create(:user) } let_it_be(:non_member) { create(:user) }
let_it_be(:project, reload: true) do let_it_be(:project, reload: true) do
create(:project).tap do |project| create(:project, :public).tap do |project|
project.add_developer(author) project.add_developer(author)
project.add_developer(member) project.add_developer(member)
end end
end end
let(:snippets) do
{
private: private_snippet,
public: public_snippet,
internal: internal_snippet
}
end
let(:user) { users[user_type] }
let(:snippet) { snippets[snippet_visibility] }
context "For project snippets" do context "For project snippets" do
let_it_be(:private_snippet) { create(:project_snippet, :private, project: project, author: author) }
let_it_be(:public_snippet) { create(:project_snippet, :public, project: project, author: author) }
let_it_be(:internal_snippet) { create(:project_snippet, :internal, project: project, author: author) }
let!(:users) do let!(:users) do
{ {
unauthenticated: nil, unauthenticated: nil,
...@@ -26,214 +41,212 @@ RSpec.shared_examples 'snippet visibility' do ...@@ -26,214 +41,212 @@ RSpec.shared_examples 'snippet visibility' do
} }
end end
where(:project_type, :feature_visibility, :user_type, :snippet_type, :outcome) do where(:project_visibility, :feature_visibility, :user_type, :snippet_visibility, :outcome) do
[ [
# Public projects # Public projects
[:public, ProjectFeature::ENABLED, :unauthenticated, Snippet::PUBLIC, true], [:public, :enabled, :unauthenticated, :public, true],
[:public, ProjectFeature::ENABLED, :unauthenticated, Snippet::INTERNAL, false], [:public, :enabled, :unauthenticated, :internal, false],
[:public, ProjectFeature::ENABLED, :unauthenticated, Snippet::PRIVATE, false], [:public, :enabled, :unauthenticated, :private, false],
[:public, ProjectFeature::ENABLED, :external, Snippet::PUBLIC, true], [:public, :enabled, :external, :public, true],
[:public, ProjectFeature::ENABLED, :external, Snippet::INTERNAL, false], [:public, :enabled, :external, :internal, false],
[:public, ProjectFeature::ENABLED, :external, Snippet::PRIVATE, false], [:public, :enabled, :external, :private, false],
[:public, ProjectFeature::ENABLED, :non_member, Snippet::PUBLIC, true], [:public, :enabled, :non_member, :public, true],
[:public, ProjectFeature::ENABLED, :non_member, Snippet::INTERNAL, true], [:public, :enabled, :non_member, :internal, true],
[:public, ProjectFeature::ENABLED, :non_member, Snippet::PRIVATE, false], [:public, :enabled, :non_member, :private, false],
[:public, ProjectFeature::ENABLED, :member, Snippet::PUBLIC, true], [:public, :enabled, :member, :public, true],
[:public, ProjectFeature::ENABLED, :member, Snippet::INTERNAL, true], [:public, :enabled, :member, :internal, true],
[:public, ProjectFeature::ENABLED, :member, Snippet::PRIVATE, true], [:public, :enabled, :member, :private, true],
[:public, ProjectFeature::ENABLED, :author, Snippet::PUBLIC, true], [:public, :enabled, :author, :public, true],
[:public, ProjectFeature::ENABLED, :author, Snippet::INTERNAL, true], [:public, :enabled, :author, :internal, true],
[:public, ProjectFeature::ENABLED, :author, Snippet::PRIVATE, true], [:public, :enabled, :author, :private, true],
[:public, ProjectFeature::PRIVATE, :unauthenticated, Snippet::PUBLIC, false], [:public, :private, :unauthenticated, :public, false],
[:public, ProjectFeature::PRIVATE, :unauthenticated, Snippet::INTERNAL, false], [:public, :private, :unauthenticated, :internal, false],
[:public, ProjectFeature::PRIVATE, :unauthenticated, Snippet::PRIVATE, false], [:public, :private, :unauthenticated, :private, false],
[:public, ProjectFeature::PRIVATE, :external, Snippet::PUBLIC, false], [:public, :private, :external, :public, false],
[:public, ProjectFeature::PRIVATE, :external, Snippet::INTERNAL, false], [:public, :private, :external, :internal, false],
[:public, ProjectFeature::PRIVATE, :external, Snippet::PRIVATE, false], [:public, :private, :external, :private, false],
[:public, ProjectFeature::PRIVATE, :non_member, Snippet::PUBLIC, false], [:public, :private, :non_member, :public, false],
[:public, ProjectFeature::PRIVATE, :non_member, Snippet::INTERNAL, false], [:public, :private, :non_member, :internal, false],
[:public, ProjectFeature::PRIVATE, :non_member, Snippet::PRIVATE, false], [:public, :private, :non_member, :private, false],
[:public, ProjectFeature::PRIVATE, :member, Snippet::PUBLIC, true], [:public, :private, :member, :public, true],
[:public, ProjectFeature::PRIVATE, :member, Snippet::INTERNAL, true], [:public, :private, :member, :internal, true],
[:public, ProjectFeature::PRIVATE, :member, Snippet::PRIVATE, true], [:public, :private, :member, :private, true],
[:public, ProjectFeature::PRIVATE, :author, Snippet::PUBLIC, true], [:public, :private, :author, :public, true],
[:public, ProjectFeature::PRIVATE, :author, Snippet::INTERNAL, true], [:public, :private, :author, :internal, true],
[:public, ProjectFeature::PRIVATE, :author, Snippet::PRIVATE, true], [:public, :private, :author, :private, true],
[:public, ProjectFeature::DISABLED, :unauthenticated, Snippet::PUBLIC, false], [:public, :disabled, :unauthenticated, :public, false],
[:public, ProjectFeature::DISABLED, :unauthenticated, Snippet::INTERNAL, false], [:public, :disabled, :unauthenticated, :internal, false],
[:public, ProjectFeature::DISABLED, :unauthenticated, Snippet::PRIVATE, false], [:public, :disabled, :unauthenticated, :private, false],
[:public, ProjectFeature::DISABLED, :external, Snippet::PUBLIC, false], [:public, :disabled, :external, :public, false],
[:public, ProjectFeature::DISABLED, :external, Snippet::INTERNAL, false], [:public, :disabled, :external, :internal, false],
[:public, ProjectFeature::DISABLED, :external, Snippet::PRIVATE, false], [:public, :disabled, :external, :private, false],
[:public, ProjectFeature::DISABLED, :non_member, Snippet::PUBLIC, false], [:public, :disabled, :non_member, :public, false],
[:public, ProjectFeature::DISABLED, :non_member, Snippet::INTERNAL, false], [:public, :disabled, :non_member, :internal, false],
[:public, ProjectFeature::DISABLED, :non_member, Snippet::PRIVATE, false], [:public, :disabled, :non_member, :private, false],
[:public, ProjectFeature::DISABLED, :member, Snippet::PUBLIC, false], [:public, :disabled, :member, :public, false],
[:public, ProjectFeature::DISABLED, :member, Snippet::INTERNAL, false], [:public, :disabled, :member, :internal, false],
[:public, ProjectFeature::DISABLED, :member, Snippet::PRIVATE, false], [:public, :disabled, :member, :private, false],
[:public, ProjectFeature::DISABLED, :author, Snippet::PUBLIC, false], [:public, :disabled, :author, :public, false],
[:public, ProjectFeature::DISABLED, :author, Snippet::INTERNAL, false], [:public, :disabled, :author, :internal, false],
[:public, ProjectFeature::DISABLED, :author, Snippet::PRIVATE, false], [:public, :disabled, :author, :private, false],
# Internal projects # Internal projects
[:internal, ProjectFeature::ENABLED, :unauthenticated, Snippet::PUBLIC, false], [:internal, :enabled, :unauthenticated, :public, false],
[:internal, ProjectFeature::ENABLED, :unauthenticated, Snippet::INTERNAL, false], [:internal, :enabled, :unauthenticated, :internal, false],
[:internal, ProjectFeature::ENABLED, :unauthenticated, Snippet::PRIVATE, false], [:internal, :enabled, :unauthenticated, :private, false],
[:internal, ProjectFeature::ENABLED, :external, Snippet::PUBLIC, false], [:internal, :enabled, :external, :public, false],
[:internal, ProjectFeature::ENABLED, :external, Snippet::INTERNAL, false], [:internal, :enabled, :external, :internal, false],
[:internal, ProjectFeature::ENABLED, :external, Snippet::PRIVATE, false], [:internal, :enabled, :external, :private, false],
[:internal, ProjectFeature::ENABLED, :non_member, Snippet::PUBLIC, true], [:internal, :enabled, :non_member, :public, true],
[:internal, ProjectFeature::ENABLED, :non_member, Snippet::INTERNAL, true], [:internal, :enabled, :non_member, :internal, true],
[:internal, ProjectFeature::ENABLED, :non_member, Snippet::PRIVATE, false], [:internal, :enabled, :non_member, :private, false],
[:internal, ProjectFeature::ENABLED, :member, Snippet::PUBLIC, true], [:internal, :enabled, :member, :public, true],
[:internal, ProjectFeature::ENABLED, :member, Snippet::INTERNAL, true], [:internal, :enabled, :member, :internal, true],
[:internal, ProjectFeature::ENABLED, :member, Snippet::PRIVATE, true], [:internal, :enabled, :member, :private, true],
[:internal, ProjectFeature::ENABLED, :author, Snippet::PUBLIC, true], [:internal, :enabled, :author, :public, true],
[:internal, ProjectFeature::ENABLED, :author, Snippet::INTERNAL, true], [:internal, :enabled, :author, :internal, true],
[:internal, ProjectFeature::ENABLED, :author, Snippet::PRIVATE, true], [:internal, :enabled, :author, :private, true],
[:internal, ProjectFeature::PRIVATE, :unauthenticated, Snippet::PUBLIC, false], [:internal, :private, :unauthenticated, :public, false],
[:internal, ProjectFeature::PRIVATE, :unauthenticated, Snippet::INTERNAL, false], [:internal, :private, :unauthenticated, :internal, false],
[:internal, ProjectFeature::PRIVATE, :unauthenticated, Snippet::PRIVATE, false], [:internal, :private, :unauthenticated, :private, false],
[:internal, ProjectFeature::PRIVATE, :external, Snippet::PUBLIC, false], [:internal, :private, :external, :public, false],
[:internal, ProjectFeature::PRIVATE, :external, Snippet::INTERNAL, false], [:internal, :private, :external, :internal, false],
[:internal, ProjectFeature::PRIVATE, :external, Snippet::PRIVATE, false], [:internal, :private, :external, :private, false],
[:internal, ProjectFeature::PRIVATE, :non_member, Snippet::PUBLIC, false], [:internal, :private, :non_member, :public, false],
[:internal, ProjectFeature::PRIVATE, :non_member, Snippet::INTERNAL, false], [:internal, :private, :non_member, :internal, false],
[:internal, ProjectFeature::PRIVATE, :non_member, Snippet::PRIVATE, false], [:internal, :private, :non_member, :private, false],
[:internal, ProjectFeature::PRIVATE, :member, Snippet::PUBLIC, true], [:internal, :private, :member, :public, true],
[:internal, ProjectFeature::PRIVATE, :member, Snippet::INTERNAL, true], [:internal, :private, :member, :internal, true],
[:internal, ProjectFeature::PRIVATE, :member, Snippet::PRIVATE, true], [:internal, :private, :member, :private, true],
[:internal, ProjectFeature::PRIVATE, :author, Snippet::PUBLIC, true], [:internal, :private, :author, :public, true],
[:internal, ProjectFeature::PRIVATE, :author, Snippet::INTERNAL, true], [:internal, :private, :author, :internal, true],
[:internal, ProjectFeature::PRIVATE, :author, Snippet::PRIVATE, true], [:internal, :private, :author, :private, true],
[:internal, ProjectFeature::DISABLED, :unauthenticated, Snippet::PUBLIC, false], [:internal, :disabled, :unauthenticated, :public, false],
[:internal, ProjectFeature::DISABLED, :unauthenticated, Snippet::INTERNAL, false], [:internal, :disabled, :unauthenticated, :internal, false],
[:internal, ProjectFeature::DISABLED, :unauthenticated, Snippet::PRIVATE, false], [:internal, :disabled, :unauthenticated, :private, false],
[:internal, ProjectFeature::DISABLED, :external, Snippet::PUBLIC, false], [:internal, :disabled, :external, :public, false],
[:internal, ProjectFeature::DISABLED, :external, Snippet::INTERNAL, false], [:internal, :disabled, :external, :internal, false],
[:internal, ProjectFeature::DISABLED, :external, Snippet::PRIVATE, false], [:internal, :disabled, :external, :private, false],
[:internal, ProjectFeature::DISABLED, :non_member, Snippet::PUBLIC, false], [:internal, :disabled, :non_member, :public, false],
[:internal, ProjectFeature::DISABLED, :non_member, Snippet::INTERNAL, false], [:internal, :disabled, :non_member, :internal, false],
[:internal, ProjectFeature::DISABLED, :non_member, Snippet::PRIVATE, false], [:internal, :disabled, :non_member, :private, false],
[:internal, ProjectFeature::DISABLED, :member, Snippet::PUBLIC, false], [:internal, :disabled, :member, :public, false],
[:internal, ProjectFeature::DISABLED, :member, Snippet::INTERNAL, false], [:internal, :disabled, :member, :internal, false],
[:internal, ProjectFeature::DISABLED, :member, Snippet::PRIVATE, false], [:internal, :disabled, :member, :private, false],
[:internal, ProjectFeature::DISABLED, :author, Snippet::PUBLIC, false], [:internal, :disabled, :author, :public, false],
[:internal, ProjectFeature::DISABLED, :author, Snippet::INTERNAL, false], [:internal, :disabled, :author, :internal, false],
[:internal, ProjectFeature::DISABLED, :author, Snippet::PRIVATE, false], [:internal, :disabled, :author, :private, false],
# Private projects # Private projects
[:private, ProjectFeature::ENABLED, :unauthenticated, Snippet::PUBLIC, false], [:private, :enabled, :unauthenticated, :public, false],
[:private, ProjectFeature::ENABLED, :unauthenticated, Snippet::INTERNAL, false], [:private, :enabled, :unauthenticated, :internal, false],
[:private, ProjectFeature::ENABLED, :unauthenticated, Snippet::PRIVATE, false], [:private, :enabled, :unauthenticated, :private, false],
[:private, ProjectFeature::ENABLED, :external, Snippet::PUBLIC, true], [:private, :enabled, :external, :public, true],
[:private, ProjectFeature::ENABLED, :external, Snippet::INTERNAL, true], [:private, :enabled, :external, :internal, true],
[:private, ProjectFeature::ENABLED, :external, Snippet::PRIVATE, true], [:private, :enabled, :external, :private, true],
[:private, ProjectFeature::ENABLED, :non_member, Snippet::PUBLIC, false], [:private, :enabled, :non_member, :public, false],
[:private, ProjectFeature::ENABLED, :non_member, Snippet::INTERNAL, false], [:private, :enabled, :non_member, :internal, false],
[:private, ProjectFeature::ENABLED, :non_member, Snippet::PRIVATE, false], [:private, :enabled, :non_member, :private, false],
[:private, ProjectFeature::ENABLED, :member, Snippet::PUBLIC, true], [:private, :enabled, :member, :public, true],
[:private, ProjectFeature::ENABLED, :member, Snippet::INTERNAL, true], [:private, :enabled, :member, :internal, true],
[:private, ProjectFeature::ENABLED, :member, Snippet::PRIVATE, true], [:private, :enabled, :member, :private, true],
[:private, ProjectFeature::ENABLED, :author, Snippet::PUBLIC, true], [:private, :enabled, :author, :public, true],
[:private, ProjectFeature::ENABLED, :author, Snippet::INTERNAL, true], [:private, :enabled, :author, :internal, true],
[:private, ProjectFeature::ENABLED, :author, Snippet::PRIVATE, true], [:private, :enabled, :author, :private, true],
[:private, ProjectFeature::PRIVATE, :unauthenticated, Snippet::PUBLIC, false], [:private, :private, :unauthenticated, :public, false],
[:private, ProjectFeature::PRIVATE, :unauthenticated, Snippet::INTERNAL, false], [:private, :private, :unauthenticated, :internal, false],
[:private, ProjectFeature::PRIVATE, :unauthenticated, Snippet::PRIVATE, false], [:private, :private, :unauthenticated, :private, false],
[:private, ProjectFeature::PRIVATE, :external, Snippet::PUBLIC, true], [:private, :private, :external, :public, true],
[:private, ProjectFeature::PRIVATE, :external, Snippet::INTERNAL, true], [:private, :private, :external, :internal, true],
[:private, ProjectFeature::PRIVATE, :external, Snippet::PRIVATE, true], [:private, :private, :external, :private, true],
[:private, ProjectFeature::PRIVATE, :non_member, Snippet::PUBLIC, false], [:private, :private, :non_member, :public, false],
[:private, ProjectFeature::PRIVATE, :non_member, Snippet::INTERNAL, false], [:private, :private, :non_member, :internal, false],
[:private, ProjectFeature::PRIVATE, :non_member, Snippet::PRIVATE, false], [:private, :private, :non_member, :private, false],
[:private, ProjectFeature::PRIVATE, :member, Snippet::PUBLIC, true], [:private, :private, :member, :public, true],
[:private, ProjectFeature::PRIVATE, :member, Snippet::INTERNAL, true], [:private, :private, :member, :internal, true],
[:private, ProjectFeature::PRIVATE, :member, Snippet::PRIVATE, true], [:private, :private, :member, :private, true],
[:private, ProjectFeature::PRIVATE, :author, Snippet::PUBLIC, true], [:private, :private, :author, :public, true],
[:private, ProjectFeature::PRIVATE, :author, Snippet::INTERNAL, true], [:private, :private, :author, :internal, true],
[:private, ProjectFeature::PRIVATE, :author, Snippet::PRIVATE, true], [:private, :private, :author, :private, true],
[:private, ProjectFeature::DISABLED, :unauthenticated, Snippet::PUBLIC, false], [:private, :disabled, :unauthenticated, :public, false],
[:private, ProjectFeature::DISABLED, :unauthenticated, Snippet::INTERNAL, false], [:private, :disabled, :unauthenticated, :internal, false],
[:private, ProjectFeature::DISABLED, :unauthenticated, Snippet::PRIVATE, false], [:private, :disabled, :unauthenticated, :private, false],
[:private, ProjectFeature::DISABLED, :external, Snippet::PUBLIC, false], [:private, :disabled, :external, :public, false],
[:private, ProjectFeature::DISABLED, :external, Snippet::INTERNAL, false], [:private, :disabled, :external, :internal, false],
[:private, ProjectFeature::DISABLED, :external, Snippet::PRIVATE, false], [:private, :disabled, :external, :private, false],
[:private, ProjectFeature::DISABLED, :non_member, Snippet::PUBLIC, false], [:private, :disabled, :non_member, :public, false],
[:private, ProjectFeature::DISABLED, :non_member, Snippet::INTERNAL, false], [:private, :disabled, :non_member, :internal, false],
[:private, ProjectFeature::DISABLED, :non_member, Snippet::PRIVATE, false], [:private, :disabled, :non_member, :private, false],
[:private, ProjectFeature::DISABLED, :member, Snippet::PUBLIC, false], [:private, :disabled, :member, :public, false],
[:private, ProjectFeature::DISABLED, :member, Snippet::INTERNAL, false], [:private, :disabled, :member, :internal, false],
[:private, ProjectFeature::DISABLED, :member, Snippet::PRIVATE, false], [:private, :disabled, :member, :private, false],
[:private, ProjectFeature::DISABLED, :author, Snippet::PUBLIC, false], [:private, :disabled, :author, :public, false],
[:private, ProjectFeature::DISABLED, :author, Snippet::INTERNAL, false], [:private, :disabled, :author, :internal, false],
[:private, ProjectFeature::DISABLED, :author, Snippet::PRIVATE, false] [:private, :disabled, :author, :private, false]
] ]
end end
with_them do with_them do
let!(:project_visibility) { project.update_column(:visibility_level, Gitlab::VisibilityLevel.level_value(project_type.to_s)) } before do
let!(:project_feature) { project.project_feature.update_column(:snippets_access_level, feature_visibility) } project.update!(visibility_level: Gitlab::VisibilityLevel.level_value(project_visibility.to_s), snippets_access_level: feature_visibility)
let!(:user) { users[user_type] }
let!(:snippet) { create(:project_snippet, visibility_level: snippet_type, project: project, author: author) } if user_type == :external
let!(:external_member) do member = project.project_member(external)
member = project.project_member(external)
if project.private?
if project.private? project.add_developer(external) unless member
project.add_developer(external) unless member else
else member.delete if member
member.delete if member end
end end
end end
context "For #{params[:project_type]} project and #{params[:user_type]} users" do context "For #{params[:project_type]} project and #{params[:user_type]} users" do
it 'agrees with the read_snippet policy' do it 'returns proper outcome' do
expect(can?(user, :read_snippet, snippet)).to eq(outcome) expect(can?(user, :read_snippet, snippet)).to eq(outcome)
end
it 'returns proper outcome' do
results = described_class.new(user, project: project).execute results = described_class.new(user, project: project).execute
expect(results.include?(snippet)).to eq(outcome) expect(results.include?(snippet)).to eq(outcome)
...@@ -243,16 +256,8 @@ RSpec.shared_examples 'snippet visibility' do ...@@ -243,16 +256,8 @@ RSpec.shared_examples 'snippet visibility' do
context "Without a given project and #{params[:user_type]} users" do context "Without a given project and #{params[:user_type]} users" do
it 'returns proper outcome' do it 'returns proper outcome' do
results = described_class.new(user).execute results = described_class.new(user).execute
expect(results.include?(snippet)).to eq(outcome)
end
it 'returns no snippets when the user cannot read cross project' do expect(results.include?(snippet)).to eq(outcome)
allow(Ability).to receive(:allowed?).and_call_original
allow(Ability).to receive(:allowed?).with(user, :read_cross_project) { false }
snippets = described_class.new(user).execute
expect(snippets).to be_empty
end end
end end
end end
...@@ -270,46 +275,55 @@ RSpec.shared_examples 'snippet visibility' do ...@@ -270,46 +275,55 @@ RSpec.shared_examples 'snippet visibility' do
where(:snippet_visibility, :user_type, :outcome) do where(:snippet_visibility, :user_type, :outcome) do
[ [
[Snippet::PUBLIC, :unauthenticated, true], [:public, :unauthenticated, true],
[Snippet::PUBLIC, :external, true], [:public, :external, true],
[Snippet::PUBLIC, :non_member, true], [:public, :non_member, true],
[Snippet::PUBLIC, :author, true], [:public, :author, true],
[Snippet::INTERNAL, :unauthenticated, false], [:internal, :unauthenticated, false],
[Snippet::INTERNAL, :external, false], [:internal, :external, false],
[Snippet::INTERNAL, :non_member, true], [:internal, :non_member, true],
[Snippet::INTERNAL, :author, true], [:internal, :author, true],
[Snippet::PRIVATE, :unauthenticated, false], [:private, :unauthenticated, false],
[Snippet::PRIVATE, :external, false], [:private, :external, false],
[Snippet::PRIVATE, :non_member, false], [:private, :non_member, false],
[Snippet::PRIVATE, :author, true] [:private, :author, true]
] ]
end end
with_them do with_them do
let!(:user) { users[user_type] } let_it_be(:private_snippet) { create(:personal_snippet, :private, author: author) }
let!(:snippet) { create(:personal_snippet, visibility_level: snippet_visibility, author: author) } let_it_be(:public_snippet) { create(:personal_snippet, :public, author: author) }
let_it_be(:internal_snippet) { create(:personal_snippet, :internal, author: author) }
context "For personal and #{params[:snippet_visibility]} snippets with #{params[:user_type]} user" do context "For personal and #{params[:snippet_visibility]} snippets with #{params[:user_type]} user" do
it 'agrees with read_snippet policy' do it 'returns proper outcome' do
expect(can?(user, :read_snippet, snippet)).to eq(outcome) expect(can?(user, :read_snippet, snippet)).to eq(outcome)
end
it 'returns proper outcome' do
results = described_class.new(user).execute results = described_class.new(user).execute
expect(results.include?(snippet)).to eq(outcome) expect(results.include?(snippet)).to eq(outcome)
end end
end
end
end
it 'returns personal snippets when the user cannot read cross project' do context 'when the user cannot read cross project' do
allow(Ability).to receive(:allowed?).and_call_original it 'returns only personal snippets' do
allow(Ability).to receive(:allowed?).with(user, :read_cross_project) { false } personal_snippet = create(:personal_snippet, :public, author: author)
create(:project_snippet, :public, project: project, author: author)
results = described_class.new(user).execute allow(Ability).to receive(:allowed?).and_call_original
allow(Ability).to receive(:allowed?).with(author, :read_cross_project) { false }
expect(results.include?(snippet)).to eq(outcome) service = described_class.new(author)
end
end expect(service).to receive(:personal_snippets).and_call_original
expect(service).not_to receive(:snippets_of_visible_projects)
expect(service).not_to receive(:snippets_of_authorized_projects)
expect(service.execute).to match_array([personal_snippet])
end end
end end
end end
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7