Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
cc218cd7
Commit
cc218cd7
authored
Feb 19, 2020
by
Heinrich Lee Yu
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove use of hard-coded ID in spec
Queries for the maximum to make sure we pass in a non-existent group ID
parent
c299e39f
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
3 additions
and
1 deletion
+3
-1
ee/spec/requests/api/groups_spec.rb
ee/spec/requests/api/groups_spec.rb
+3
-1
No files found.
ee/spec/requests/api/groups_spec.rb
View file @
cc218cd7
...
@@ -248,7 +248,9 @@ describe API::Groups do
...
@@ -248,7 +248,9 @@ describe API::Groups do
end
end
it
'returns 404 for a non existing group'
do
it
'returns 404 for a non existing group'
do
ldap_sync
(
1328
,
user
,
:disable!
)
non_existent_group_id
=
Group
.
maximum
(
:id
).
to_i
+
1
ldap_sync
(
non_existent_group_id
,
user
,
:disable!
)
expect
(
response
).
to
have_gitlab_http_status
(
404
)
expect
(
response
).
to
have_gitlab_http_status
(
404
)
end
end
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment