Commit cd4cf100 authored by Andrew Fontaine's avatar Andrew Fontaine

Merge branch '292636-fix-scroll-issue' into 'master'

Fix scrolling issues with sticky header

See merge request gitlab-org/gitlab!55188
parents d7b2f981 94f8155d
...@@ -95,11 +95,11 @@ export default { ...@@ -95,11 +95,11 @@ export default {
</script> </script>
<template> <template>
<div> <div class="card gl-z-index-2!" :class="{ 'with-error': Boolean(updateErrorText) }">
<gl-alert v-if="updateErrorText" variant="danger" :dismissible="false" class="gl-mb-3"> <gl-alert v-if="updateErrorText" variant="danger" :dismissible="false">
{{ updateErrorText }} {{ updateErrorText }}
</gl-alert> </gl-alert>
<div class="card gl-z-index-3!">
<form class="card-body gl-display-flex gl-align-items-center" @submit.prevent="handleSubmit"> <form class="card-body gl-display-flex gl-align-items-center" @submit.prevent="handleSubmit">
<div <div
class="gl-line-height-0 gl-border-r-solid gl-border-gray-100 gl-pr-6 gl-border-1 gl-h-7 gl-display-flex gl-align-items-center" class="gl-line-height-0 gl-border-r-solid gl-border-gray-100 gl-pr-6 gl-border-1 gl-h-7 gl-display-flex gl-align-items-center"
...@@ -121,5 +121,4 @@ export default { ...@@ -121,5 +121,4 @@ export default {
</template> </template>
</form> </form>
</div> </div>
</div>
</template> </template>
@import 'page_bundles/mixins_and_variables_and_functions'; @import 'page_bundles/mixins_and_variables_and_functions';
$security-filter-height: 90px; $security-filter-height: 90px;
$selection-summary-height: 68px; $selection-summary-height: 66px;
$selection-summary-with-error-height: 118px;
@mixin sticky-top-positioning($extra: 0) { @mixin sticky-top-positioning($extra: 0) {
top: $header-height + $extra; top: $header-height + $extra;
...@@ -113,4 +114,8 @@ $selection-summary-height: 68px; ...@@ -113,4 +114,8 @@ $selection-summary-height: 68px;
tr:hover .vulnerability-title { tr:hover .vulnerability-title {
text-decoration: underline; text-decoration: underline;
} }
.card.with-error + table thead.below-selection-summary th {
@include sticky-top-positioning($security-filter-height + $selection-summary-with-error-height);
}
} }
---
title: Fix scrolling issues with sticky status box
merge_request: 55188
author:
type: fixed
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment