Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
cf4848c4
Commit
cf4848c4
authored
Aug 10, 2021
by
Luke Duncalfe
Committed by
Alex Kalderimis
Aug 10, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix Rubocop Graphql/Description offenses
https://gitlab.com/gitlab-org/gitlab/-/issues/337596
parent
d59437fc
Changes
31
Expand all
Show whitespace changes
Inline
Side-by-side
Showing
31 changed files
with
116 additions
and
145 deletions
+116
-145
.rubocop_manual_todo.yml
.rubocop_manual_todo.yml
+0
-29
app/graphql/mutations/admin/sidekiq_queues/delete_jobs.rb
app/graphql/mutations/admin/sidekiq_queues/delete_jobs.rb
+1
-1
app/graphql/mutations/alert_management/alerts/set_assignees.rb
...raphql/mutations/alert_management/alerts/set_assignees.rb
+2
-2
app/graphql/mutations/alert_management/base.rb
app/graphql/mutations/alert_management/base.rb
+5
-5
app/graphql/mutations/alert_management/http_integration/create.rb
...hql/mutations/alert_management/http_integration/create.rb
+2
-2
app/graphql/mutations/alert_management/http_integration/destroy.rb
...ql/mutations/alert_management/http_integration/destroy.rb
+1
-1
app/graphql/mutations/alert_management/http_integration/http_integration_base.rb
...lert_management/http_integration/http_integration_base.rb
+1
-1
app/graphql/mutations/alert_management/http_integration/reset_token.rb
...utations/alert_management/http_integration/reset_token.rb
+1
-1
app/graphql/mutations/alert_management/http_integration/update.rb
...hql/mutations/alert_management/http_integration/update.rb
+2
-2
app/graphql/mutations/alert_management/prometheus_integration/create.rb
...tations/alert_management/prometheus_integration/create.rb
+1
-1
app/graphql/mutations/alert_management/prometheus_integration/prometheus_integration_base.rb
...ent/prometheus_integration/prometheus_integration_base.rb
+1
-1
app/graphql/mutations/alert_management/prometheus_integration/reset_token.rb
...ns/alert_management/prometheus_integration/reset_token.rb
+1
-1
app/graphql/mutations/alert_management/prometheus_integration/update.rb
...tations/alert_management/prometheus_integration/update.rb
+1
-1
app/graphql/mutations/alert_management/update_alert_status.rb
...graphql/mutations/alert_management/update_alert_status.rb
+1
-1
app/graphql/mutations/award_emojis/base.rb
app/graphql/mutations/award_emojis/base.rb
+2
-2
app/graphql/mutations/boards/common_mutation_arguments.rb
app/graphql/mutations/boards/common_mutation_arguments.rb
+1
-1
app/graphql/mutations/boards/create.rb
app/graphql/mutations/boards/create.rb
+1
-1
app/graphql/mutations/boards/destroy.rb
app/graphql/mutations/boards/destroy.rb
+2
-2
app/graphql/mutations/boards/lists/destroy.rb
app/graphql/mutations/boards/lists/destroy.rb
+1
-1
app/graphql/mutations/boards/update.rb
app/graphql/mutations/boards/update.rb
+2
-2
app/graphql/mutations/ci/ci_cd_settings_update.rb
app/graphql/mutations/ci/ci_cd_settings_update.rb
+1
-1
app/graphql/mutations/ci/job/base.rb
app/graphql/mutations/ci/job/base.rb
+1
-1
app/graphql/mutations/ci/job/play.rb
app/graphql/mutations/ci/job/play.rb
+1
-1
app/graphql/mutations/ci/job/retry.rb
app/graphql/mutations/ci/job/retry.rb
+1
-1
app/graphql/mutations/ci/job_token_scope/add_project.rb
app/graphql/mutations/ci/job_token_scope/add_project.rb
+3
-3
app/graphql/mutations/ci/job_token_scope/remove_project.rb
app/graphql/mutations/ci/job_token_scope/remove_project.rb
+3
-3
app/graphql/mutations/ci/pipeline/base.rb
app/graphql/mutations/ci/pipeline/base.rb
+1
-1
app/graphql/mutations/ci/pipeline/retry.rb
app/graphql/mutations/ci/pipeline/retry.rb
+1
-1
app/graphql/mutations/ci/runner/update.rb
app/graphql/mutations/ci/runner/update.rb
+1
-1
app/graphql/mutations/ci/runners_registration_token/reset.rb
app/graphql/mutations/ci/runners_registration_token/reset.rb
+1
-1
doc/api/graphql/reference/index.md
doc/api/graphql/reference/index.md
+73
-73
No files found.
.rubocop_manual_todo.yml
View file @
cf4848c4
...
...
@@ -22,35 +22,6 @@ Graphql/Descriptions:
-
'
ee/app/graphql/types/vulnerability_report_type_enum.rb'
-
'
ee/app/graphql/types/vulnerability_severity_enum.rb'
-
'
ee/app/graphql/types/vulnerability_state_enum.rb'
-
'
app/graphql/mutations/admin/sidekiq_queues/delete_jobs.rb'
-
'
app/graphql/mutations/alert_management/alerts/set_assignees.rb'
-
'
app/graphql/mutations/alert_management/base.rb'
-
'
app/graphql/mutations/alert_management/http_integration/create.rb'
-
'
app/graphql/mutations/alert_management/http_integration/destroy.rb'
-
'
app/graphql/mutations/alert_management/http_integration/http_integration_base.rb'
-
'
app/graphql/mutations/alert_management/http_integration/reset_token.rb'
-
'
app/graphql/mutations/alert_management/http_integration/update.rb'
-
'
app/graphql/mutations/alert_management/prometheus_integration/create.rb'
-
'
app/graphql/mutations/alert_management/prometheus_integration/prometheus_integration_base.rb'
-
'
app/graphql/mutations/alert_management/prometheus_integration/reset_token.rb'
-
'
app/graphql/mutations/alert_management/prometheus_integration/update.rb'
-
'
app/graphql/mutations/alert_management/update_alert_status.rb'
-
'
app/graphql/mutations/award_emojis/base.rb'
-
'
app/graphql/mutations/boards/common_mutation_arguments.rb'
-
'
app/graphql/mutations/boards/create.rb'
-
'
app/graphql/mutations/boards/destroy.rb'
-
'
app/graphql/mutations/boards/lists/destroy.rb'
-
'
app/graphql/mutations/boards/update.rb'
-
'
app/graphql/mutations/ci/ci_cd_settings_update.rb'
-
'
app/graphql/mutations/ci/job/base.rb'
-
'
app/graphql/mutations/ci/job/play.rb'
-
'
app/graphql/mutations/ci/job/retry.rb'
-
'
app/graphql/mutations/ci/job_token_scope/add_project.rb'
-
'
app/graphql/mutations/ci/job_token_scope/remove_project.rb'
-
'
app/graphql/mutations/ci/pipeline/base.rb'
-
'
app/graphql/mutations/ci/pipeline/retry.rb'
-
'
app/graphql/mutations/ci/runner/update.rb'
-
'
app/graphql/mutations/ci/runners_registration_token/reset.rb'
-
'
app/graphql/mutations/commits/create.rb'
-
'
app/graphql/mutations/concerns/mutations/assignable.rb'
-
'
app/graphql/mutations/concerns/mutations/can_mutate_spammable.rb'
...
...
app/graphql/mutations/admin/sidekiq_queues/delete_jobs.rb
View file @
cf4848c4
...
...
@@ -18,7 +18,7 @@ module Mutations
argument
:queue_name
,
GraphQL
::
Types
::
String
,
required:
true
,
description:
'
The n
ame of the queue to delete jobs from.'
description:
'
N
ame of the queue to delete jobs from.'
field
:result
,
Types
::
Admin
::
SidekiqQueues
::
DeleteJobsResponseType
,
...
...
app/graphql/mutations/alert_management/alerts/set_assignees.rb
View file @
cf4848c4
...
...
@@ -9,12 +9,12 @@ module Mutations
argument
:assignee_usernames
,
[
GraphQL
::
Types
::
String
],
required:
true
,
description:
'
The u
sernames to assign to the alert. Replaces existing assignees by default.'
description:
'
U
sernames to assign to the alert. Replaces existing assignees by default.'
argument
:operation_mode
,
Types
::
MutationOperationModeEnum
,
required:
false
,
description:
'
The o
peration to perform. Defaults to REPLACE.'
description:
'
O
peration to perform. Defaults to REPLACE.'
def
resolve
(
args
)
alert
=
authorized_find!
(
project_path:
args
[
:project_path
],
iid:
args
[
:iid
])
...
...
app/graphql/mutations/alert_management/base.rb
View file @
cf4848c4
...
...
@@ -7,26 +7,26 @@ module Mutations
argument
:project_path
,
GraphQL
::
Types
::
ID
,
required:
true
,
description:
"
The p
roject the alert to mutate is in."
description:
"
P
roject the alert to mutate is in."
argument
:iid
,
GraphQL
::
Types
::
String
,
required:
true
,
description:
"
The
IID of the alert to mutate."
description:
"IID of the alert to mutate."
field
:alert
,
Types
::
AlertManagement
::
AlertType
,
null:
true
,
description:
"
The a
lert after mutation."
description:
"
A
lert after mutation."
field
:todo
,
Types
::
TodoType
,
null:
true
,
description:
"T
he t
o-do item after mutation."
description:
"To-do item after mutation."
field
:issue
,
Types
::
IssueType
,
null:
true
,
description:
"
The i
ssue created after mutation."
description:
"
I
ssue created after mutation."
authorize
:update_alert_management_alert
...
...
app/graphql/mutations/alert_management/http_integration/create.rb
View file @
cf4848c4
...
...
@@ -10,11 +10,11 @@ module Mutations
argument
:project_path
,
GraphQL
::
Types
::
ID
,
required:
true
,
description:
'
The p
roject to create the integration in.'
description:
'
P
roject to create the integration in.'
argument
:name
,
GraphQL
::
Types
::
String
,
required:
true
,
description:
'
The n
ame of the integration.'
description:
'
N
ame of the integration.'
argument
:active
,
GraphQL
::
Types
::
Boolean
,
required:
true
,
...
...
app/graphql/mutations/alert_management/http_integration/destroy.rb
View file @
cf4848c4
...
...
@@ -8,7 +8,7 @@ module Mutations
argument
:id
,
Types
::
GlobalIDType
[
::
AlertManagement
::
HttpIntegration
],
required:
true
,
description:
"
The
ID of the integration to remove."
description:
"ID of the integration to remove."
def
resolve
(
id
:)
integration
=
authorized_find!
(
id:
id
)
...
...
app/graphql/mutations/alert_management/http_integration/http_integration_base.rb
View file @
cf4848c4
...
...
@@ -7,7 +7,7 @@ module Mutations
field
:integration
,
Types
::
AlertManagement
::
HttpIntegrationType
,
null:
true
,
description:
"
The
HTTP integration."
description:
"HTTP integration."
authorize
:admin_operations
...
...
app/graphql/mutations/alert_management/http_integration/reset_token.rb
View file @
cf4848c4
...
...
@@ -8,7 +8,7 @@ module Mutations
argument
:id
,
Types
::
GlobalIDType
[
::
AlertManagement
::
HttpIntegration
],
required:
true
,
description:
"
The
ID of the integration to mutate."
description:
"ID of the integration to mutate."
def
resolve
(
id
:)
integration
=
authorized_find!
(
id:
id
)
...
...
app/graphql/mutations/alert_management/http_integration/update.rb
View file @
cf4848c4
...
...
@@ -8,11 +8,11 @@ module Mutations
argument
:id
,
Types
::
GlobalIDType
[
::
AlertManagement
::
HttpIntegration
],
required:
true
,
description:
"
The
ID of the integration to mutate."
description:
"ID of the integration to mutate."
argument
:name
,
GraphQL
::
Types
::
String
,
required:
false
,
description:
"
The n
ame of the integration."
description:
"
N
ame of the integration."
argument
:active
,
GraphQL
::
Types
::
Boolean
,
required:
false
,
...
...
app/graphql/mutations/alert_management/prometheus_integration/create.rb
View file @
cf4848c4
...
...
@@ -10,7 +10,7 @@ module Mutations
argument
:project_path
,
GraphQL
::
Types
::
ID
,
required:
true
,
description:
'
The p
roject to create the integration in.'
description:
'
P
roject to create the integration in.'
argument
:active
,
GraphQL
::
Types
::
Boolean
,
required:
true
,
...
...
app/graphql/mutations/alert_management/prometheus_integration/prometheus_integration_base.rb
View file @
cf4848c4
...
...
@@ -7,7 +7,7 @@ module Mutations
field
:integration
,
Types
::
AlertManagement
::
PrometheusIntegrationType
,
null:
true
,
description:
"
The n
ewly created integration."
description:
"
N
ewly created integration."
authorize
:admin_project
...
...
app/graphql/mutations/alert_management/prometheus_integration/reset_token.rb
View file @
cf4848c4
...
...
@@ -8,7 +8,7 @@ module Mutations
argument
:id
,
Types
::
GlobalIDType
[
::
Integrations
::
Prometheus
],
required:
true
,
description:
"
The
ID of the integration to mutate."
description:
"ID of the integration to mutate."
def
resolve
(
id
:)
integration
=
authorized_find!
(
id:
id
)
...
...
app/graphql/mutations/alert_management/prometheus_integration/update.rb
View file @
cf4848c4
...
...
@@ -8,7 +8,7 @@ module Mutations
argument
:id
,
Types
::
GlobalIDType
[
::
Integrations
::
Prometheus
],
required:
true
,
description:
"
The
ID of the integration to mutate."
description:
"ID of the integration to mutate."
argument
:active
,
GraphQL
::
Types
::
Boolean
,
required:
false
,
...
...
app/graphql/mutations/alert_management/update_alert_status.rb
View file @
cf4848c4
...
...
@@ -7,7 +7,7 @@ module Mutations
argument
:status
,
Types
::
AlertManagement
::
StatusEnum
,
required:
true
,
description:
'
The s
tatus to set the alert.'
description:
'
S
tatus to set the alert.'
def
resolve
(
project_path
:,
iid
:,
status
:)
alert
=
authorized_find!
(
project_path:
project_path
,
iid:
iid
)
...
...
app/graphql/mutations/award_emojis/base.rb
View file @
cf4848c4
...
...
@@ -12,7 +12,7 @@ module Mutations
argument
:awardable_id
,
::
Types
::
GlobalIDType
[
::
Awardable
],
required:
true
,
description:
'
The g
lobal ID of the awardable resource.'
description:
'
G
lobal ID of the awardable resource.'
argument
:name
,
GraphQL
::
Types
::
String
,
...
...
@@ -22,7 +22,7 @@ module Mutations
field
:award_emoji
,
Types
::
AwardEmojis
::
AwardEmojiType
,
null:
true
,
description:
'
The a
ward emoji after mutation.'
description:
'
A
ward emoji after mutation.'
private
...
...
app/graphql/mutations/boards/common_mutation_arguments.rb
View file @
cf4848c4
...
...
@@ -9,7 +9,7 @@ module Mutations
argument
:name
,
GraphQL
::
Types
::
String
,
required:
false
,
description:
'
The b
oard name.'
description:
'
B
oard name.'
argument
:hide_backlog_list
,
GraphQL
::
Types
::
Boolean
,
required:
false
,
...
...
app/graphql/mutations/boards/create.rb
View file @
cf4848c4
...
...
@@ -12,7 +12,7 @@ module Mutations
field
:board
,
Types
::
BoardType
,
null:
true
,
description:
'
The b
oard after mutation.'
description:
'
B
oard after mutation.'
authorize
:admin_issue_board
...
...
app/graphql/mutations/boards/destroy.rb
View file @
cf4848c4
...
...
@@ -8,11 +8,11 @@ module Mutations
field
:board
,
Types
::
BoardType
,
null:
true
,
description:
'
The b
oard after mutation.'
description:
'
B
oard after mutation.'
argument
:id
,
::
Types
::
GlobalIDType
[
::
Board
],
required:
true
,
description:
'
The g
lobal ID of the board to destroy.'
description:
'
G
lobal ID of the board to destroy.'
authorize
:admin_issue_board
...
...
app/graphql/mutations/boards/lists/destroy.rb
View file @
cf4848c4
...
...
@@ -9,7 +9,7 @@ module Mutations
field
:list
,
Types
::
BoardListType
,
null:
true
,
description:
'
The l
ist after mutation.'
description:
'
L
ist after mutation.'
argument
:list_id
,
::
Types
::
GlobalIDType
[
::
List
],
required:
true
,
...
...
app/graphql/mutations/boards/update.rb
View file @
cf4848c4
...
...
@@ -10,12 +10,12 @@ module Mutations
argument
:id
,
::
Types
::
GlobalIDType
[
::
Board
],
required:
true
,
description:
'
The b
oard global ID.'
description:
'
B
oard global ID.'
field
:board
,
Types
::
BoardType
,
null:
true
,
description:
'
The b
oard after mutation.'
description:
'
B
oard after mutation.'
authorize
:admin_issue_board
...
...
app/graphql/mutations/ci/ci_cd_settings_update.rb
View file @
cf4848c4
...
...
@@ -24,7 +24,7 @@ module Mutations
field
:ci_cd_settings
,
Types
::
Ci
::
CiCdSettingType
,
null:
false
,
description:
'
The
CI/CD settings after mutation.'
description:
'CI/CD settings after mutation.'
def
resolve
(
full_path
:,
**
args
)
project
=
authorized_find!
(
full_path
)
...
...
app/graphql/mutations/ci/job/base.rb
View file @
cf4848c4
...
...
@@ -8,7 +8,7 @@ module Mutations
argument
:id
,
JobID
,
required:
true
,
description:
'
The
ID of the job to mutate.'
description:
'ID of the job to mutate.'
def
find_object
(
id:
)
# TODO: remove this line when the compatibility layer is removed
...
...
app/graphql/mutations/ci/job/play.rb
View file @
cf4848c4
...
...
@@ -9,7 +9,7 @@ module Mutations
field
:job
,
Types
::
Ci
::
JobType
,
null:
true
,
description:
'
The j
ob after the mutation.'
description:
'
J
ob after the mutation.'
authorize
:update_build
...
...
app/graphql/mutations/ci/job/retry.rb
View file @
cf4848c4
...
...
@@ -9,7 +9,7 @@ module Mutations
field
:job
,
Types
::
Ci
::
JobType
,
null:
true
,
description:
'
The j
ob after the mutation.'
description:
'
J
ob after the mutation.'
authorize
:update_build
...
...
app/graphql/mutations/ci/job_token_scope/add_project.rb
View file @
cf4848c4
...
...
@@ -12,16 +12,16 @@ module Mutations
argument
:project_path
,
GraphQL
::
Types
::
ID
,
required:
true
,
description:
'
The p
roject that the CI job token scope belongs to.'
description:
'
P
roject that the CI job token scope belongs to.'
argument
:target_project_path
,
GraphQL
::
Types
::
ID
,
required:
true
,
description:
'
The p
roject to be added to the CI job token scope.'
description:
'
P
roject to be added to the CI job token scope.'
field
:ci_job_token_scope
,
Types
::
Ci
::
JobTokenScopeType
,
null:
true
,
description:
"
The
CI job token's scope of access."
description:
"CI job token's scope of access."
def
resolve
(
project_path
:,
target_project_path
:)
project
=
authorized_find!
(
project_path
)
...
...
app/graphql/mutations/ci/job_token_scope/remove_project.rb
View file @
cf4848c4
...
...
@@ -12,16 +12,16 @@ module Mutations
argument
:project_path
,
GraphQL
::
Types
::
ID
,
required:
true
,
description:
'
The p
roject that the CI job token scope belongs to.'
description:
'
P
roject that the CI job token scope belongs to.'
argument
:target_project_path
,
GraphQL
::
Types
::
ID
,
required:
true
,
description:
'
The p
roject to be removed from the CI job token scope.'
description:
'
P
roject to be removed from the CI job token scope.'
field
:ci_job_token_scope
,
Types
::
Ci
::
JobTokenScopeType
,
null:
true
,
description:
"
The
CI job token's scope of access."
description:
"CI job token's scope of access."
def
resolve
(
project_path
:,
target_project_path
:)
project
=
authorized_find!
(
project_path
)
...
...
app/graphql/mutations/ci/pipeline/base.rb
View file @
cf4848c4
...
...
@@ -8,7 +8,7 @@ module Mutations
argument
:id
,
PipelineID
,
required:
true
,
description:
'
The
ID of the pipeline to mutate.'
description:
'ID of the pipeline to mutate.'
private
...
...
app/graphql/mutations/ci/pipeline/retry.rb
View file @
cf4848c4
...
...
@@ -9,7 +9,7 @@ module Mutations
field
:pipeline
,
Types
::
Ci
::
PipelineType
,
null:
true
,
description:
'
The p
ipeline after mutation.'
description:
'
P
ipeline after mutation.'
authorize
:update_pipeline
...
...
app/graphql/mutations/ci/runner/update.rb
View file @
cf4848c4
...
...
@@ -43,7 +43,7 @@ module Mutations
field
:runner
,
Types
::
Ci
::
RunnerType
,
null:
true
,
description:
'
The r
unner after mutation.'
description:
'
R
unner after mutation.'
def
resolve
(
id
:,
**
runner_attrs
)
runner
=
authorized_find!
(
id
)
...
...
app/graphql/mutations/ci/runners_registration_token/reset.rb
View file @
cf4848c4
...
...
@@ -21,7 +21,7 @@ module Mutations
field
:token
,
GraphQL
::
Types
::
String
,
null:
true
,
description:
'
The r
unner token after mutation.'
description:
'
R
unner token after mutation.'
def
resolve
(
**
args
)
{
...
...
doc/api/graphql/reference/index.md
View file @
cf4848c4
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment