Commit d17baf9d authored by Kushal Pandya's avatar Kushal Pandya

Merge branch 'unify_feature_flags' into 'master'

Rename jira_integration FF to match licensed feature

See merge request gitlab-org/gitlab!36943
parents 6fa8b695 88e06925
...@@ -53,7 +53,7 @@ export default { ...@@ -53,7 +53,7 @@ export default {
return this.type === 'jira'; return this.type === 'jira';
}, },
showJiraIssuesFields() { showJiraIssuesFields() {
return this.isJira && this.glFeatures.jiraIntegration; return this.isJira && this.glFeatures.jiraIssuesIntegration;
}, },
}, },
}; };
......
...@@ -36,7 +36,7 @@ function mountIssuableListRootApp() { ...@@ -36,7 +36,7 @@ function mountIssuableListRootApp() {
} }
function mountIssuablesListApp() { function mountIssuablesListApp() {
if (!gon.features?.vueIssuablesList && !gon.features?.jiraIntegration) { if (!gon.features?.vueIssuablesList && !gon.features?.jiraIssuesIntegration) {
return; return;
} }
......
...@@ -13,7 +13,7 @@ class Projects::ServicesController < Projects::ApplicationController ...@@ -13,7 +13,7 @@ class Projects::ServicesController < Projects::ApplicationController
before_action :redirect_deprecated_prometheus_service, only: [:update] before_action :redirect_deprecated_prometheus_service, only: [:update]
before_action only: :edit do before_action only: :edit do
push_frontend_feature_flag(:integration_form_refactor, default_enabled: true) push_frontend_feature_flag(:integration_form_refactor, default_enabled: true)
push_frontend_feature_flag(:jira_integration, @project) push_frontend_feature_flag(:jira_issues_integration, @project, { default_enabled: true })
end end
respond_to :html respond_to :html
......
...@@ -11,7 +11,7 @@ module Projects ...@@ -11,7 +11,7 @@ module Projects
before_action :check_feature_enabled! before_action :check_feature_enabled!
before_action do before_action do
push_frontend_feature_flag(:jira_integration, project) push_frontend_feature_flag(:jira_issues_integration, project, { default_enabled: true })
end end
rescue_from ::Projects::Integrations::Jira::IssuesFinder::IntegrationError, with: :render_integration_error rescue_from ::Projects::Integrations::Jira::IssuesFinder::IntegrationError, with: :render_integration_error
......
...@@ -88,17 +88,17 @@ describe('IntegrationForm', () => { ...@@ -88,17 +88,17 @@ describe('IntegrationForm', () => {
expect(findJiraTriggerFields().exists()).toBe(true); expect(findJiraTriggerFields().exists()).toBe(true);
}); });
describe('featureFlag jiraIntegration is false', () => { describe('featureFlag jiraIssuesIntegration is false', () => {
it('does not render JiraIssuesFields', () => { it('does not render JiraIssuesFields', () => {
createComponent({ type: 'jira' }, { jiraIntegration: false }); createComponent({ type: 'jira' }, { jiraIssuesIntegration: false });
expect(findJiraIssuesFields().exists()).toBe(false); expect(findJiraIssuesFields().exists()).toBe(false);
}); });
}); });
describe('featureFlag jiraIntegration is true', () => { describe('featureFlag jiraIssuesIntegration is true', () => {
it('renders JiraIssuesFields', () => { it('renders JiraIssuesFields', () => {
createComponent({ type: 'jira' }, { jiraIntegration: true }); createComponent({ type: 'jira' }, { jiraIssuesIntegration: true });
expect(findJiraIssuesFields().exists()).toBe(true); expect(findJiraIssuesFields().exists()).toBe(true);
}); });
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment