Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
d24ad831
Commit
d24ad831
authored
Dec 01, 2020
by
Rémy Coutable
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
e2e: Add missing let that led to project creation when loading the file
Signed-off-by:
Rémy Coutable
<
remy@rymai.me
>
parent
5704c69e
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
18 additions
and
8 deletions
+18
-8
qa/qa/specs/features/api/3_create/merge_request/push_options_labels_spec.rb
...es/api/3_create/merge_request/push_options_labels_spec.rb
+18
-8
No files found.
qa/qa/specs/features/api/3_create/merge_request/push_options_labels_spec.rb
View file @
d24ad831
...
...
@@ -7,16 +7,18 @@ module QA
#
# git config --global receive.advertisepushoptions true
branch
=
"push-options-test-
#{
SecureRandom
.
hex
(
8
)
}
"
title
=
"MR push options test
#{
SecureRandom
.
hex
(
8
)
}
"
commit_message
=
'Add README.md'
let
(
:branch
)
{
"push-options-test-
#{
SecureRandom
.
hex
(
8
)
}
"
}
let
(
:title
)
{
"MR push options test
#{
SecureRandom
.
hex
(
8
)
}
"
}
let
(
:commit_message
)
{
'Add README.md'
}
project
=
Resource
::
Project
.
fabricate_via_api!
do
|
project
|
let
(
:project
)
do
Resource
::
Project
.
fabricate_via_api!
do
|
project
|
project
.
name
=
'merge-request-push-options'
project
.
initialize_with_readme
=
true
end
end
it
'sets labels'
,
testcase:
'https://gitlab.com/gitlab-org/quality/testcases/-/issues/1032'
do
def
create_new_mr_via_push
Resource
::
Repository
::
ProjectPush
.
fabricate!
do
|
push
|
push
.
project
=
project
push
.
commit_message
=
commit_message
...
...
@@ -27,6 +29,10 @@ module QA
label:
%w[one two three]
}
end
end
it
'sets labels'
,
testcase:
'https://gitlab.com/gitlab-org/quality/testcases/-/issues/1032'
do
create_new_mr_via_push
merge_request
=
project
.
merge_request_with_title
(
title
)
...
...
@@ -35,7 +41,11 @@ module QA
end
context
'when labels are set already'
do
it
'removes them'
,
testcase:
'https://gitlab.com/gitlab-org/quality/testcases/-/issues/1033'
do
before
do
create_new_mr_via_push
end
it
'removes them on subsequent push'
,
testcase:
'https://gitlab.com/gitlab-org/quality/testcases/-/issues/1033'
do
Resource
::
Repository
::
ProjectPush
.
fabricate!
do
|
push
|
push
.
project
=
project
push
.
file_content
=
"Unlabel test
#{
SecureRandom
.
hex
(
8
)
}
"
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment