Merge branch '208723-check-feature-once' into 'master'

Remove feature flag

See merge request gitlab-org/gitlab!43200

ee/app/models/ee/ci/build.rb

@@ -79,8 +79,6 @@ module EE
         return license_scanning_report unless project.feature_available?(:license_scanning)
 
         each_report(::Ci::JobArtifact::LICENSE_SCANNING_REPORT_FILE_TYPES) do |file_type, blob|
-          next if ::Feature.disabled?(:parse_license_management_reports, default_enabled: true)
-
           ::Gitlab::Ci::Parsers.fabricate!(file_type).parse!(blob, license_scanning_report)
         end
 

ee/config/feature_flags/development/parse_license_management_reports.yml

----
-name: parse_license_management_reports
-introduced_by_url: 
-rollout_issue_url: 
-group: 
-type: development
-default_enabled: true

ee/spec/factories/ci/reports/license_scanning/report.rb

 # frozen_string_literal: true
 
 FactoryBot.define do
-  factory :ci_reports_license_scanning_report, class: '::Gitlab::Ci::Reports::LicenseScanning::Report', aliases: [:license_scan_report] do
+  factory :ci_reports_license_scanning_report, class: '::Gitlab::Ci::Reports::LicenseScanning::Report', aliases: [:license_scan_report, :license_scanning_report] do
     trait :version_1 do
       version { '1.0' }
     end

ee/spec/models/ci/build_spec.rb

@@ -227,15 +227,15 @@ RSpec.describe Ci::Build do
   describe '#collect_license_scanning_reports!' do
     subject { job.collect_license_scanning_reports!(license_scanning_report) }
 
-    let(:license_scanning_report) { Gitlab::Ci::Reports::LicenseScanning::Report.new }
-
-    before do
-      stub_licensed_features(license_scanning: true)
-    end
+    let(:license_scanning_report) { build(:license_scanning_report) }
 
     it { expect(license_scanning_report.licenses.count).to eq(0) }
 
-    context 'when build has a license scanning report' do
+    context 'when the build has a license scanning report' do
+      before do
+        stub_licensed_features(license_scanning: true)
+      end
+
       context 'when there is a new type report' do
         before do
           create(:ee_ci_job_artifact, :license_scanning, job: job, project: job.project)
@@ -275,19 +275,6 @@ RSpec.describe Ci::Build do
         end
       end
 
-      context 'when Feature flag is disabled for License Scanning reports parsing' do
-        before do
-          stub_feature_flags(parse_license_management_reports: false)
-          create(:ee_ci_job_artifact, :license_scanning, job: job, project: job.project)
-        end
-
-        it 'does NOT parse license scanning report' do
-          subject
-
-          expect(license_scanning_report.licenses.count).to eq(0)
-        end
-      end
-
       context 'when the license scanning feature is disabled' do
         before do
           stub_licensed_features(license_scanning: false)