Commit d55f0a77 authored by Olena Horal-Koretska's avatar Olena Horal-Koretska

Merge branch...

Merge branch '229155-clarify-checking-ability-to-merge-automatically-message-on-mr-widget' into 'master'

Change loading message for merge widget

Closes #229155

See merge request gitlab-org/gitlab!37181
parents ea04e393 c4f203de
...@@ -12,7 +12,7 @@ export default { ...@@ -12,7 +12,7 @@ export default {
<div class="mr-widget-body media"> <div class="mr-widget-body media">
<status-icon :show-disabled-button="true" status="loading" /> <status-icon :show-disabled-button="true" status="loading" />
<div class="media-body space-children"> <div class="media-body space-children">
<span class="bold"> {{ s__('mrWidget|Checking ability to merge automatically') }} </span> <span class="bold"> {{ s__('mrWidget|Checking if merge request can be merged') }} </span>
</div> </div>
</div> </div>
</template> </template>
---
title: Change loading MR message wording
merge_request: 37181
author:
type: changed
...@@ -97,7 +97,7 @@ RSpec.xdescribe 'Merge request > User approves', :js do ...@@ -97,7 +97,7 @@ RSpec.xdescribe 'Merge request > User approves', :js do
end end
it 'does not show checking ability text' do it 'does not show checking ability text' do
expect(find('.js-mr-approvals')).not_to have_text('Checking ability to merge automatically') expect(find('.js-mr-approvals')).not_to have_text('Checking if merge request can be merged')
expect(find('.js-mr-approvals')).to have_selector('.approvals-body') expect(find('.js-mr-approvals')).to have_selector('.approvals-body')
end end
end end
......
...@@ -24,7 +24,7 @@ RSpec.describe 'Merge request > User sees approval widget', :js do ...@@ -24,7 +24,7 @@ RSpec.describe 'Merge request > User sees approval widget', :js do
# TODO: https://gitlab.com/gitlab-org/gitlab/issues/9430 # TODO: https://gitlab.com/gitlab-org/gitlab/issues/9430
xit 'does not show checking ability text' do xit 'does not show checking ability text' do
expect(find('.js-mr-approvals')).not_to have_text('Checking ability to merge automatically') expect(find('.js-mr-approvals')).not_to have_text('Checking if merge request can be merged')
expect(find('.js-mr-approvals')).to have_selector('.approvals-body') expect(find('.js-mr-approvals')).to have_selector('.approvals-body')
end end
end end
......
...@@ -28286,7 +28286,7 @@ msgstr "" ...@@ -28286,7 +28286,7 @@ msgstr ""
msgid "mrWidget|Check out branch" msgid "mrWidget|Check out branch"
msgstr "" msgstr ""
msgid "mrWidget|Checking ability to merge automatically…" msgid "mrWidget|Checking if merge request can be merged…"
msgstr "" msgstr ""
msgid "mrWidget|Cherry-pick" msgid "mrWidget|Cherry-pick"
......
...@@ -25,7 +25,7 @@ describe('MRWidgetChecking', () => { ...@@ -25,7 +25,7 @@ describe('MRWidgetChecking', () => {
it('renders information about merging', () => { it('renders information about merging', () => {
expect(vm.$el.querySelector('.media-body').textContent.trim()).toEqual( expect(vm.$el.querySelector('.media-body').textContent.trim()).toEqual(
'Checking ability to merge automatically', 'Checking if merge request can be merged',
); );
}); });
}); });
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment