Commit d5b52019 authored by Jarka Košanová's avatar Jarka Košanová

Merge branch 'fix-some-epic-tests' into 'master'

Avoid potentially existing id, and fix 404 test

See merge request gitlab-org/gitlab!25967
parents 3d495244 174801d3
...@@ -132,7 +132,7 @@ describe Groups::EpicIssuesController do ...@@ -132,7 +132,7 @@ describe Groups::EpicIssuesController do
end end
context 'when user does not have permissions to delete the link' do context 'when user does not have permissions to delete the link' do
it 'returns status 404' do it 'returns status 403' do
subject subject
expect(response.status).to eq(403) expect(response.status).to eq(403)
...@@ -167,9 +167,11 @@ describe Groups::EpicIssuesController do ...@@ -167,9 +167,11 @@ describe Groups::EpicIssuesController do
context 'when the epic_issue record does not exists' do context 'when the epic_issue record does not exists' do
it 'returns status 404' do it 'returns status 404' do
delete :destroy, params: { group_id: group, epic_id: epic.to_param, id: 9999 } group.add_developer(user)
expect(response.status).to eq(403) delete :destroy, params: { group_id: group, epic_id: epic.to_param, id: 0 }
expect(response.status).to eq(404)
end end
end end
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment