Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
d6e2c896
Commit
d6e2c896
authored
May 05, 2021
by
Mike Greiling
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove old namespace select dropdown implementation
parent
ab3ef1b4
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
0 additions
and
123 deletions
+0
-123
app/assets/javascripts/namespace_select.js
app/assets/javascripts/namespace_select.js
+0
-58
spec/frontend/namespace_select_spec.js
spec/frontend/namespace_select_spec.js
+0
-65
No files found.
app/assets/javascripts/namespace_select.js
deleted
100644 → 0
View file @
ab3ef1b4
import
$
from
'
jquery
'
;
import
initDeprecatedJQueryDropdown
from
'
~/deprecated_jquery_dropdown
'
;
import
{
parseBoolean
}
from
'
~/lib/utils/common_utils
'
;
import
Api
from
'
./api
'
;
import
{
mergeUrlParams
}
from
'
./lib/utils/url_utility
'
;
import
{
__
}
from
'
./locale
'
;
export
default
class
NamespaceSelect
{
constructor
(
opts
)
{
const
isFilter
=
parseBoolean
(
opts
.
dropdown
.
dataset
.
isFilter
);
const
fieldName
=
opts
.
dropdown
.
dataset
.
fieldName
||
'
namespace_id
'
;
initDeprecatedJQueryDropdown
(
$
(
opts
.
dropdown
),
{
filterable
:
true
,
selectable
:
true
,
filterRemote
:
true
,
search
:
{
fields
:
[
'
path
'
],
},
fieldName
,
toggleLabel
(
selected
)
{
if
(
selected
.
id
==
null
)
{
return
selected
.
text
;
}
return
`
${
selected
.
kind
}
:
${
selected
.
full_path
}
`
;
},
data
(
term
,
dataCallback
)
{
return
Api
.
namespaces
(
term
,
(
namespaces
)
=>
{
if
(
isFilter
)
{
const
anyNamespace
=
{
text
:
__
(
'
Any namespace
'
),
id
:
null
,
};
namespaces
.
unshift
(
anyNamespace
);
namespaces
.
splice
(
1
,
0
,
{
type
:
'
divider
'
});
}
return
dataCallback
(
namespaces
);
});
},
text
(
namespace
)
{
if
(
namespace
.
id
==
null
)
{
return
namespace
.
text
;
}
return
`
${
namespace
.
kind
}
:
${
namespace
.
full_path
}
`
;
},
renderRow
:
this
.
renderRow
,
clicked
(
options
)
{
if
(
!
isFilter
)
{
const
{
e
}
=
options
;
e
.
preventDefault
();
}
},
url
(
namespace
)
{
return
mergeUrlParams
({
[
fieldName
]:
namespace
.
id
},
window
.
location
.
href
);
},
});
}
}
spec/frontend/namespace_select_spec.js
deleted
100644 → 0
View file @
ab3ef1b4
import
initDeprecatedJQueryDropdown
from
'
~/deprecated_jquery_dropdown
'
;
import
NamespaceSelect
from
'
~/namespace_select
'
;
jest
.
mock
(
'
~/deprecated_jquery_dropdown
'
);
describe
(
'
NamespaceSelect
'
,
()
=>
{
it
(
'
initializes deprecatedJQueryDropdown
'
,
()
=>
{
const
dropdown
=
document
.
createElement
(
'
div
'
);
// eslint-disable-next-line no-new
new
NamespaceSelect
({
dropdown
});
expect
(
initDeprecatedJQueryDropdown
).
toHaveBeenCalled
();
});
describe
(
'
as input
'
,
()
=>
{
let
deprecatedJQueryDropdownOptions
;
beforeEach
(()
=>
{
const
dropdown
=
document
.
createElement
(
'
div
'
);
// eslint-disable-next-line no-new
new
NamespaceSelect
({
dropdown
});
[[,
deprecatedJQueryDropdownOptions
]]
=
initDeprecatedJQueryDropdown
.
mock
.
calls
;
});
it
(
'
prevents click events
'
,
()
=>
{
const
dummyEvent
=
new
Event
(
'
dummy
'
);
jest
.
spyOn
(
dummyEvent
,
'
preventDefault
'
).
mockImplementation
(()
=>
{});
// expect(foo).toContain('test');
deprecatedJQueryDropdownOptions
.
clicked
({
e
:
dummyEvent
});
expect
(
dummyEvent
.
preventDefault
).
toHaveBeenCalled
();
});
});
describe
(
'
as filter
'
,
()
=>
{
let
deprecatedJQueryDropdownOptions
;
beforeEach
(()
=>
{
const
dropdown
=
document
.
createElement
(
'
div
'
);
dropdown
.
dataset
.
isFilter
=
'
true
'
;
// eslint-disable-next-line no-new
new
NamespaceSelect
({
dropdown
});
[[,
deprecatedJQueryDropdownOptions
]]
=
initDeprecatedJQueryDropdown
.
mock
.
calls
;
});
it
(
'
does not prevent click events
'
,
()
=>
{
const
dummyEvent
=
new
Event
(
'
dummy
'
);
jest
.
spyOn
(
dummyEvent
,
'
preventDefault
'
).
mockImplementation
(()
=>
{});
deprecatedJQueryDropdownOptions
.
clicked
({
e
:
dummyEvent
});
expect
(
dummyEvent
.
preventDefault
).
not
.
toHaveBeenCalled
();
});
it
(
'
sets URL of dropdown items
'
,
()
=>
{
const
dummyNamespace
=
{
id
:
'
eal
'
};
const
itemUrl
=
deprecatedJQueryDropdownOptions
.
url
(
dummyNamespace
);
expect
(
itemUrl
).
toContain
(
`namespace_id=
${
dummyNamespace
.
id
}
`
);
});
});
});
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment