Merge branch 'remove-a11y-widget-ff' into 'master'

Remove a11y widget feature flag

See merge request gitlab-org/gitlab!32902

app/models/merge_request.rb

@@ -1313,8 +1313,6 @@ class MergeRequest < ApplicationRecord
   end
 
   def has_accessibility_reports?
-    return false unless Feature.enabled?(:accessibility_report_view, project)
-
     actual_head_pipeline.present? && actual_head_pipeline.has_reports?(Ci::JobArtifact.accessibility_reports)
   end
 

changelogs/unreleased/remove-a11y-widget-ff.yml

+---
+title: Add accessibility report MR widget
+merge_request: 32902
+author:
+type: added

doc/user/project/merge_requests/accessibility_testing.md

@@ -25,16 +25,6 @@ Accessibility Report in the merge request widget area:
 
 ![Accessibility Merge Request Widget](img/accessibility_mr_widget_v13_0.png)
 
-This widget comes with the `:accessibility_report_view` feature flag disabled by default while we test feature stability.
-Once we have determined the widget is stable, this feature will be enabled by default.
-
-To enable this feature, ask a GitLab administrator with [Rails console access](../../../administration/feature_flags.md#how-to-enable-and-disable-features-behind-flags) to run the
-following command:
-
-```ruby
-Feature.enable(:accessibility_report_view)
-```
-
 ## Configure Accessibility Testing
 
 This example shows how to run [pa11y](https://pa11y.org/)

spec/controllers/projects/merge_requests_controller_spec.rb

@@ -1409,20 +1409,6 @@ describe Projects::MergeRequestsController do
       end
     end
 
-    context 'when feature flag is disabled' do
-      let(:accessibility_comparison) { { status: :parsed, data: { summary: 1 } } }
-
-      before do
-        stub_feature_flags(accessibility_report_view: false)
-      end
-
-      it 'returns 204 HTTP status' do
-        subject
-
-        expect(response).to have_gitlab_http_status(:no_content)
-      end
-    end
-
     context 'when pipeline has jobs with accessibility reports' do
       before do
         allow_any_instance_of(MergeRequest)

spec/models/merge_request_spec.rb

@@ -1651,14 +1651,6 @@ describe MergeRequest do
       let(:merge_request) { create(:merge_request, :with_accessibility_reports, source_project: project) }
 
       it { is_expected.to be_truthy }
-
-      context 'when feature flag is disabled' do
-        before do
-          stub_feature_flags(accessibility_report_view: false)
-        end
-
-        it { is_expected.to be_falsey }
-      end
     end
 
     context 'when head pipeline does not have accessibility reports' do