Commit d87e813c authored by Lukas Eipert's avatar Lukas Eipert

Fix autocomplete limitation bug

jQuery at.js has a hard limit on how many items can be searched. Before
it executes it's search function, it limits the array size to 1000
items. We have been hitting this bug because we have more than a
thousand users or labels [0][1].

We are planning to replace at.js [2], but in order to fix this bug for
now, we have forked at.js [3] and made adjustments, so that it works for
our usecases.

Performance wise this should have no big impact, as we are rendering a
maximum of 5 results in the most cases anyway. The search on the
javascript side is rather performant.

[0]: https://gitlab.com/gitlab-org/gitlab/issues/204825
[1]: https://gitlab.com/gitlab-org/gitlab/issues/198650
[2]: https://gitlab.com/gitlab-org/gitlab/issues/27240
[3]: https://gitlab.com/gitlab-org/frontend/At.js
parent 45176203
---
title: Fix autocomplete limitation bug
merge_request: 25127
author:
type: fixed
......@@ -201,6 +201,7 @@
"yarn-deduplicate": "^1.1.1"
},
"resolutions": {
"at.js": "https://gitlab.com/gitlab-org/frontend/At.js.git#121ce9a557b51c33f5693ac8df52d2bda1e53cbe",
"vue-jest/ts-jest": "24.0.0",
"monaco-editor": "0.18.1"
},
......
......@@ -1774,10 +1774,9 @@ asynckit@^0.4.0:
resolved "https://registry.yarnpkg.com/asynckit/-/asynckit-0.4.0.tgz#c79ed97f7f34cb8f2ba1bc9790bcc366474b4b79"
integrity sha1-x57Zf380y48robyXkLzDZkdLS3k=
at.js@^1.5.4:
at.js@^1.5.4, "at.js@https://gitlab.com/gitlab-org/frontend/At.js.git#121ce9a557b51c33f5693ac8df52d2bda1e53cbe":
version "1.5.4"
resolved "https://registry.yarnpkg.com/at.js/-/at.js-1.5.4.tgz#8fc60cc80eadbe4874449b166a818e7ae1d784c1"
integrity sha512-G8mgUb/PqShPoH8AyjuxsTGvIr1o716BtQUKDM44C8qN2W615y7KGJ68MlTGamd0J0D/m28emUkzagaHTdrGZw==
resolved "https://gitlab.com/gitlab-org/frontend/At.js.git#121ce9a557b51c33f5693ac8df52d2bda1e53cbe"
atob@^2.1.1:
version "2.1.2"
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment