Commit dac3a45a authored by Tom Quirk's avatar Tom Quirk

Remove unnecessary props from todo_button

parent bd99c8b6
......@@ -7,20 +7,12 @@ export default {
GlButton,
},
props: {
issuableId: {
type: Number,
required: true,
},
issuableType: {
type: String,
required: true,
},
isTodo: {
type: Boolean,
required: false,
default: true,
},
isActionActive: {
loading: {
type: Boolean,
required: false,
default: false,
......@@ -31,23 +23,11 @@ export default {
return this.isTodo ? __('Mark as done') : __('Add a To-Do');
},
},
methods: {
toggleTodo() {
this.$emit('toggleTodo', {
issuableType: this.issuableType,
issuableId: this.issuableId,
});
},
},
};
</script>
<template>
<div>
<slot :toggleTodo="toggleTodo" :label="buttonLabel">
<gl-button :loading="isActionActive" :aria-label="buttonLabel" @click="toggleTodo">
<gl-button :loading="loading" :aria-label="buttonLabel" @click="$emit('click', $event)">
{{ buttonLabel }}
</gl-button></slot
>
</div>
</gl-button>
</template>
import { mount } from '@vue/test-utils';
import { GlButton, GlLoadingIcon } from '@gitlab/ui';
import { shallowMount, mount } from '@vue/test-utils';
import { GlButton } from '@gitlab/ui';
import TodoButton from '~/vue_shared/components/todo_button.vue';
const defaultProps = {
issuableId: 1,
issuableType: 'epic',
};
describe('Todo Button', () => {
let wrapper;
const createComponent = (props = {}) => {
wrapper = mount(TodoButton, {
const createComponent = (props = {}, mountFn = shallowMount) => {
wrapper = mountFn(TodoButton, {
propsData: {
...defaultProps,
...props,
},
});
......@@ -29,12 +23,11 @@ describe('Todo Button', () => {
expect(wrapper.find(GlButton).exists()).toBe(true);
});
it('emits toggleTodo event when clicked', () => {
createComponent();
it('emits click event when clicked', () => {
createComponent({}, mount);
wrapper.find(GlButton).trigger('click');
expect(wrapper.emitted().toggleTodo).toBeTruthy();
expect(wrapper.emitted().toggleTodo[0]).toEqual([defaultProps]);
expect(wrapper.emitted().click).toBeTruthy();
});
it.each`
......@@ -47,9 +40,9 @@ describe('Todo Button', () => {
expect(wrapper.find(GlButton).text()).toBe(label);
});
it('renders loading icon when `isActionActive` is true', () => {
createComponent({ isActionActive: true });
it('sets button props correctly when `loading` is true', () => {
createComponent({ loading: true });
expect(wrapper.find(GlLoadingIcon).exists()).toBe(true);
expect(wrapper.find(GlButton).props('loading')).toBe(true);
});
});
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment