Merge branch '241815-enable-site-validation-ff' into 'master'

Enable site validation feature flag by default

See merge request gitlab-org/gitlab!50847

config/feature_flags/development/security_on_demand_scans_site_validation.yml

@@ -5,4 +5,4 @@ rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/241815
 milestone: '13.4'
 type: development
 group: group::dynamic analysis
-default_enabled: false
+default_enabled: true

ee/app/controllers/projects/on_demand_scans_controller.rb

@@ -3,7 +3,7 @@
 module Projects
   class OnDemandScansController < Projects::ApplicationController
     before_action do
-      push_frontend_feature_flag(:security_on_demand_scans_site_validation, @project)
+      push_frontend_feature_flag(:security_on_demand_scans_site_validation, @project, default_enabled: :yaml)
       push_frontend_feature_flag(:security_dast_site_profiles_additional_fields, @project, default_enabled: :yaml)
       push_frontend_feature_flag(:dast_saved_scans, @project, default_enabled: :yaml)
     end

ee/app/controllers/projects/security/dast_profiles_controller.rb

@@ -5,7 +5,7 @@ module Projects
     class DastProfilesController < Projects::ApplicationController
       before_action do
         authorize_read_on_demand_scans!
-        push_frontend_feature_flag(:security_on_demand_scans_site_validation, @project)
+        push_frontend_feature_flag(:security_on_demand_scans_site_validation, @project, default_enabled: :yaml)
       end
 
       feature_category :dynamic_application_security_testing

ee/app/graphql/mutations/dast_site_tokens/create.rb

@@ -46,7 +46,7 @@ module Mutations
       private
 
       def allowed?(project)
-        Feature.enabled?(:security_on_demand_scans_site_validation, project)
+        Feature.enabled?(:security_on_demand_scans_site_validation, project, default_enabled: :yaml)
       end
 
       def error_response(errors)

ee/app/graphql/mutations/dast_site_validations/create.rb

@@ -56,7 +56,7 @@ module Mutations
       private
 
       def allowed?(project)
-        Feature.enabled?(:security_on_demand_scans_site_validation, project)
+        Feature.enabled?(:security_on_demand_scans_site_validation, project, default_enabled: :yaml)
       end
 
       def error_response(errors)

ee/app/graphql/resolvers/dast_site_validation_resolver.rb

@@ -18,7 +18,7 @@ module Resolvers
     private
 
     def allowed?
-      ::Feature.enabled?(:security_on_demand_scans_site_validation, project)
+      ::Feature.enabled?(:security_on_demand_scans_site_validation, project, default_enabled: :yaml)
     end
   end
 end

ee/app/services/dast_site_tokens/create_service.rb

@@ -30,7 +30,7 @@ module DastSiteTokens
 
     def allowed?
       container.feature_available?(:security_on_demand_scans) &&
-        Feature.enabled?(:security_on_demand_scans_site_validation, container)
+        Feature.enabled?(:security_on_demand_scans_site_validation, container, default_enabled: :yaml)
     end
 
     def normalize_target_url(target_url)

ee/app/services/dast_site_validations/create_service.rb

@@ -23,7 +23,7 @@ module DastSiteValidations
 
     def allowed?
       container.feature_available?(:security_on_demand_scans) &&
-        Feature.enabled?(:security_on_demand_scans_site_validation, container) &&
+        Feature.enabled?(:security_on_demand_scans_site_validation, container, default_enabled: :yaml) &&
         dast_site_token.project == container
     end
 

ee/app/services/dast_site_validations/validate_service.rb

@@ -25,7 +25,7 @@ module DastSiteValidations
 
     def allowed?
       container.feature_available?(:security_on_demand_scans) &&
-        Feature.enabled?(:security_on_demand_scans_site_validation, container)
+        Feature.enabled?(:security_on_demand_scans_site_validation, container, default_enabled: :yaml)
     end
 
     def dast_site_validation

ee/changelogs/unreleased/241815-enable-site-validation-ff.yml

+---
+title: Add ability to validate DAST site profiles
+merge_request: 50847
+author:
+type: added