Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
dbcd6462
Commit
dbcd6462
authored
Nov 22, 2015
by
Robert Speicher
Committed by
Robert Speicher
Nov 21, 2015
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Merge branch 'award_fix' into 'master'
Emoji bug: Invalid url to image Closes #3591 See merge request !1868
parent
aeaa5b50
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
2 additions
and
2 deletions
+2
-2
app/assets/javascripts/awards_handler.coffee
app/assets/javascripts/awards_handler.coffee
+1
-1
app/controllers/projects/notes_controller.rb
app/controllers/projects/notes_controller.rb
+1
-1
No files found.
app/assets/javascripts/awards_handler.coffee
View file @
dbcd6462
...
@@ -73,7 +73,7 @@ class @AwardsHandler
...
@@ -73,7 +73,7 @@ class @AwardsHandler
getImage
:
(
emoji
,
custom_path
)
->
getImage
:
(
emoji
,
custom_path
)
->
if
custom_path
if
custom_path
$
(
"
.awards-menu li"
).
first
().
html
().
replace
(
/emoji\/.*\.png/
,
custom_path
)
$
(
"
<img>"
).
attr
({
src
:
custom_path
,
width
:
20
,
height
:
20
}).
wrap
(
"<div>"
).
parent
().
html
(
)
else
else
$
(
"li[data-emoji='"
+
emoji
+
"']"
).
html
()
$
(
"li[data-emoji='"
+
emoji
+
"']"
).
html
()
...
...
app/controllers/projects/notes_controller.rb
View file @
dbcd6462
...
@@ -136,7 +136,7 @@ class Projects::NotesController < Projects::ApplicationController
...
@@ -136,7 +136,7 @@ class Projects::NotesController < Projects::ApplicationController
discussion_id:
note
.
discussion_id
,
discussion_id:
note
.
discussion_id
,
html:
note_to_html
(
note
),
html:
note_to_html
(
note
),
award:
note
.
is_award
,
award:
note
.
is_award
,
emoji_path:
note
.
is_award
?
::
AwardEmoji
.
path_to_emoji_image
(
note
.
note
)
:
""
,
emoji_path:
note
.
is_award
?
view_context
.
image_url
(
::
AwardEmoji
.
path_to_emoji_image
(
note
.
note
)
)
:
""
,
note:
note
.
note
,
note:
note
.
note
,
discussion_html:
note_to_discussion_html
(
note
),
discussion_html:
note_to_discussion_html
(
note
),
discussion_with_diff_html:
note_to_discussion_with_diff_html
(
note
)
discussion_with_diff_html:
note_to_discussion_with_diff_html
(
note
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment