Commit dc80afd2 authored by Tiger's avatar Tiger

Remove cross-db modification exception in Clusters::Applications::Runner

Managed cluster applications are no longer available, so we can remove
this logic entirely.
parent e14d2414
...@@ -41,9 +41,7 @@ module Clusters ...@@ -41,9 +41,7 @@ module Clusters
end end
def prepare_uninstall def prepare_uninstall
::Gitlab::Database::QueryAnalyzers::PreventCrossDatabaseModification.allow_cross_database_modification_within_transaction(url: 'https://gitlab.com/gitlab-org/gitlab/-/issues/350180') do # No op, see https://gitlab.com/gitlab-org/gitlab/-/issues/350180.
runner&.update!(active: false)
end
end end
def post_uninstall def post_uninstall
......
...@@ -101,19 +101,6 @@ RSpec.describe Clusters::Applications::Runner do ...@@ -101,19 +101,6 @@ RSpec.describe Clusters::Applications::Runner do
end end
end end
describe '#prepare_uninstall' do
it 'pauses associated runner' do
active_runner = create(:ci_runner, contacted_at: 1.second.ago)
expect(active_runner.active).to be_truthy
application_runner = create(:clusters_applications_runner, :scheduled, runner: active_runner)
application_runner.prepare_uninstall
expect(active_runner.active).to be_falsey
end
end
describe '#make_uninstalling!' do describe '#make_uninstalling!' do
subject { create(:clusters_applications_runner, :scheduled, runner: ci_runner) } subject { create(:clusters_applications_runner, :scheduled, runner: ci_runner) }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment