Commit de2c9df1 authored by Clement Ho's avatar Clement Ho

Merge branch 'winh-eslint-no-jquery/no-animate' into 'master'

Disable ESLint rule no-jquery/no-animate inline

See merge request gitlab-org/gitlab!21879
parents 858555fa 323d01f3
...@@ -45,7 +45,6 @@ rules: ...@@ -45,7 +45,6 @@ rules:
vue/no-use-v-if-with-v-for: off vue/no-use-v-if-with-v-for: off
vue/no-v-html: off vue/no-v-html: off
vue/use-v-on-exact: off vue/use-v-on-exact: off
no-jquery/no-animate: off
# all offenses of no-jquery/no-animate-toggle are false positives ( $toast.show() ) # all offenses of no-jquery/no-animate-toggle are false positives ( $toast.show() )
no-jquery/no-animate-toggle: off no-jquery/no-animate-toggle: off
no-jquery/no-event-shorthand: off no-jquery/no-event-shorthand: off
......
...@@ -506,6 +506,8 @@ export class AwardsHandler { ...@@ -506,6 +506,8 @@ export class AwardsHandler {
const options = { const options = {
scrollTop: $('.awards').offset().top - 110, scrollTop: $('.awards').offset().top - 110,
}; };
// eslint-disable-next-line no-jquery/no-animate
return $('body, html').animate(options, 200); return $('body, html').animate(options, 200);
} }
......
...@@ -247,6 +247,7 @@ export const scrollToElement = element => { ...@@ -247,6 +247,7 @@ export const scrollToElement = element => {
} }
const { top } = $el.offset(); const { top } = $el.offset();
// eslint-disable-next-line no-jquery/no-animate
return $('body, html').animate( return $('body, html').animate(
{ {
scrollTop: top - contentTop(), scrollTop: top - contentTop(),
......
...@@ -36,6 +36,8 @@ export default function adminInit() { ...@@ -36,6 +36,8 @@ export default function adminInit() {
$('.log-bottom').on('click', e => { $('.log-bottom').on('click', e => {
e.preventDefault(); e.preventDefault();
const $visibleLog = $('.file-content:visible'); const $visibleLog = $('.file-content:visible');
// eslint-disable-next-line no-jquery/no-animate
$visibleLog.animate( $visibleLog.animate(
{ {
scrollTop: $visibleLog.find('ol').height(), scrollTop: $visibleLog.find('ol').height(),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment